Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove mention of download-data from dev guide docs #6901

Merged
merged 2 commits into from
Jun 15, 2024
Merged

Conversation

cdeil
Copy link
Contributor

@cdeil cdeil commented Jun 7, 2024

This doesn't seem to exist:

$ pixi run download-data
download-data: command not found

Is this PR to remove the step correct? Or should I run some other command?

PS: great to see better install/dev tooling! :-)

I get errors for most steps (unit tests, UI tests, docs).
Should I report those or wait a few weeks for the next release?

@hoxbro
Copy link
Member

hoxbro commented Jun 7, 2024

That is a copy paste error from Holoviews 😅

You are welcome to report the issue, maybe join them in one issue to start with. My suspicion without seeing any thing is missing running pixi run install or missing git tags.

@hoxbro
Copy link
Member

hoxbro commented Jun 7, 2024

That is a copy paste error from Holoviews 😅

This was not correct, I removed it when updating to Bokeh 3.5 dev version in #6883

@cdeil
Copy link
Contributor Author

cdeil commented Jun 15, 2024

Ready to merge?

@hoxbro hoxbro merged commit ebd9cc2 into holoviz:main Jun 15, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants