Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure user cookie can be unencoded #6937

Merged
merged 2 commits into from
Jun 25, 2024
Merged

Ensure user cookie can be unencoded #6937

merged 2 commits into from
Jun 25, 2024

Conversation

philippjfr
Copy link
Member

Fixes #6898

Copy link

codecov bot commented Jun 25, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 72.29%. Comparing base (4e351ed) to head (d406381).

Files Patch % Lines
panel/io/application.py 0.00% 4 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (4e351ed) and HEAD (d406381). Click for more details.

HEAD has 4 uploads less than BASE | Flag | BASE (4e351ed) | HEAD (d406381) | |------|------|------| ||8|4|
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6937      +/-   ##
==========================================
- Coverage   81.16%   72.29%   -8.88%     
==========================================
  Files         323      322       -1     
  Lines       47626    47628       +2     
==========================================
- Hits        38658    34432    -4226     
- Misses       8968    13196    +4228     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@philippjfr philippjfr merged commit 497370d into main Jun 25, 2024
1 check passed
@philippjfr philippjfr deleted the fix_unencoded_user branch June 25, 2024 11:41
philippjfr added a commit that referenced this pull request Jul 10, 2024
* Ensure user cookie can be unencoded

* Skip decoding without secret
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Basic auth seems to be broken starting with panel 1.4.3
1 participant