Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix FileDownload with icon #6981

Merged
merged 2 commits into from
Jul 14, 2024
Merged

Fix FileDownload with icon #6981

merged 2 commits into from
Jul 14, 2024

Conversation

MarcSkovMadsen
Copy link
Collaborator

Closes #6972

Manual Test

import panel as pn

pn.extension()

download = pn.widgets.FileDownload(icon="cloud", file=" ", sizing_mode="stretch_width")
button = pn.widgets.Button(icon="cloud", name="Download", sizing_mode="stretch_width")

download_wo = pn.widgets.FileDownload(file=" ", sizing_mode="stretch_width")
button_wo = pn.widgets.Button(name="Download", sizing_mode="stretch_width")

pn.Column(download, button, download_wo, button_wo).servable()

image

Copy link

codecov bot commented Jul 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.72%. Comparing base (7267b38) to head (b5dba7a).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6981   +/-   ##
=======================================
  Coverage   81.71%   81.72%           
=======================================
  Files         326      326           
  Lines       48082    48082           
=======================================
+ Hits        39292    39295    +3     
+ Misses       8790     8787    -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@philippjfr philippjfr merged commit ce89243 into main Jul 14, 2024
15 checks passed
@philippjfr philippjfr deleted the fix/download-button branch July 14, 2024 15:33
philippjfr pushed a commit that referenced this pull request Jul 16, 2024
* fix filedownload with icon

* remove ;
@philippjfr philippjfr modified the milestones: next, v1.4.5 Aug 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inconsistent Button/FileDownload Icon location
2 participants