Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure Design is applied globally when using global templates #6992

Merged
merged 3 commits into from
Jul 16, 2024

Conversation

philippjfr
Copy link
Member

Includes a number of optimizations and fixes when applying a Design, specifically:

  • Always cache the creation of ImportedStyleSheet
  • If an app uses pn.state.template the template's design is applied globally (for the session)
  • Design modifiers are only applied once per model (e.g. ensuring that wrapper components have final say on the themes applied to the model)

Copy link

codecov bot commented Jul 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.72%. Comparing base (62be0e5) to head (70efef8).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6992      +/-   ##
==========================================
- Coverage   81.73%   81.72%   -0.01%     
==========================================
  Files         326      326              
  Lines       48082    48095      +13     
==========================================
+ Hits        39299    39305       +6     
- Misses       8783     8790       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@philippjfr philippjfr merged commit 2bacc0e into main Jul 16, 2024
13 of 15 checks passed
@philippjfr philippjfr deleted the optimize_design_apply branch July 16, 2024 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants