Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display value for player #7060

Merged
merged 14 commits into from
Aug 8, 2024
Merged

Display value for player #7060

merged 14 commits into from
Aug 8, 2024

Conversation

ahuang11
Copy link
Contributor

@ahuang11 ahuang11 commented Aug 2, 2024

Closes #229

Wrapping up the work @benbarn313 did on #6059 by adding support for DiscretePlayer and rename value_location to value_align to have some parallelism with Panel param align a little more

import panel as pn

pn.extension()
pn.widgets.DiscretePlayer(name="Name", show_value=True, value_align="start", value=1, options=[1, 4, 8]).show()
Screen.Recording.2024-08-02.at.12.53.14.PM.mov
import panel as pn

pn.extension()
pn.widgets.DiscretePlayer(
    name="Name", show_value=True, value_align="start", value=1, options=["a", "b", "d"]
).show()
Screen.Recording.2024-08-02.at.12.57.16.PM.mov

@ahuang11 ahuang11 marked this pull request as ready for review August 2, 2024 19:59
Copy link

codecov bot commented Aug 2, 2024

Codecov Report

Attention: Patch coverage is 85.41667% with 7 lines in your changes missing coverage. Please review.

Project coverage is 82.21%. Comparing base (071f51a) to head (e1bd9db).
Report is 9 commits behind head on main.

Files Patch % Lines
panel/tests/ui/widgets/test_player.py 80.00% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7060      +/-   ##
==========================================
- Coverage   82.23%   82.21%   -0.02%     
==========================================
  Files         326      327       +1     
  Lines       48394    48509     +115     
==========================================
+ Hits        39796    39882      +86     
- Misses       8598     8627      +29     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@philippjfr philippjfr merged commit 811d794 into main Aug 8, 2024
15 checks passed
@philippjfr philippjfr deleted the display_value_for_player branch August 8, 2024 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add current value display to Player widget
3 participants