Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve ESM layout how-to guide #7088

Merged
merged 11 commits into from
Aug 26, 2024
Merged

Improve ESM layout how-to guide #7088

merged 11 commits into from
Aug 26, 2024

Conversation

MarcSkovMadsen
Copy link
Collaborator

@MarcSkovMadsen MarcSkovMadsen commented Aug 7, 2024

The current ESM layout guide was migrated from ReactiveHTML guide. I think it could be improved by

  • Changing the topic/ example to something more clearly layout like. For example as split.js layout.
  • Adding handling for updating of children

Besides that I will

  • fix some errors introduced in the reference guide since I wrote them.

Todo:

  • Philipp: Make sure only one child (right) is updated when changed. Not both (right and left).
  • Philipp: Remove ParamFutureWarning logged when using Child parameter.
  • Philipp: Fix GridReact append and pop issue.

Copy link

codecov bot commented Aug 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.22%. Comparing base (15a8241) to head (1ec9f20).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7088      +/-   ##
==========================================
- Coverage   82.22%   82.22%   -0.01%     
==========================================
  Files         328      328              
  Lines       49267    49269       +2     
==========================================
+ Hits        40509    40510       +1     
- Misses       8758     8759       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MarcSkovMadsen MarcSkovMadsen changed the title hello world Improve ESM layout how-to guide Aug 7, 2024
@MarcSkovMadsen MarcSkovMadsen added this to the v1.5.0 milestone Aug 11, 2024
@MarcSkovMadsen MarcSkovMadsen marked this pull request as ready for review August 11, 2024 11:11
@philippjfr philippjfr merged commit 6b44a18 into main Aug 26, 2024
15 of 16 checks passed
@philippjfr philippjfr deleted the enhancement/ems-layout-guide branch August 26, 2024 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants