Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #7078
Users who run their own code in Mypy strict mode require that all calls they make are to typed interfaces.
I did initially explore the possibility of annotating these
**params
asUnpack[TypedDict]
(see PEP 692) but it was not readily apparent from the source code what all the possibilities were, and until PEP 728 is accepted this had the potential to break perfectly valid code that were using parameters that I did not anticipate. So I dropped this idea pretty quickly.But to solve the basic issue in user code, all this needs is an annotation - of any kind. So I went ahead and added an
Any
.Here is some sample code, run on Mypy strict:
Before:
After:
@MarcSkovMadsen