Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure OAuth expiry is numeric and can be compared #7191

Merged
merged 1 commit into from
Aug 27, 2024
Merged

Conversation

philippjfr
Copy link
Member

Fixes #6895

Copy link

codecov bot commented Aug 27, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 82.21%. Comparing base (3697335) to head (2bfe29f).
Report is 5 commits behind head on main.

Files Patch % Lines
panel/auth.py 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7191      +/-   ##
==========================================
+ Coverage   72.23%   82.21%   +9.98%     
==========================================
  Files         329      330       +1     
  Lines       49342    49359      +17     
==========================================
+ Hits        35640    40581    +4941     
+ Misses      13702     8778    -4924     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@philippjfr philippjfr merged commit 4907011 into main Aug 27, 2024
15 of 16 checks passed
@philippjfr philippjfr deleted the cast_expiry branch August 27, 2024 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

expiry is not cast to int when read from oauth cookie
1 participant