Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor state.notifications to fix pyodide #7235

Merged
merged 1 commit into from
Sep 7, 2024

Conversation

philippjfr
Copy link
Member

In pyodide the pn.state.notifications logic was creating a notifications object on render but not returning when the user accessed it.

Fixes #7230

Copy link

codecov bot commented Sep 7, 2024

Codecov Report

Attention: Patch coverage is 93.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 82.23%. Comparing base (d23dd3a) to head (ff03a99).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
panel/io/state.py 93.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7235      +/-   ##
==========================================
- Coverage   82.23%   82.23%   -0.01%     
==========================================
  Files         337      337              
  Lines       50225    50228       +3     
==========================================
+ Hits        41301    41303       +2     
- Misses       8924     8925       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@philippjfr philippjfr merged commit aeadfe4 into main Sep 7, 2024
16 checks passed
@philippjfr philippjfr deleted the refactor_state_notifications branch September 7, 2024 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Panel Notifications break Pyodide Sites
1 participant