Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't force conversion if dtype is object #7242

Merged
merged 3 commits into from
Sep 10, 2024
Merged

Conversation

hoxbro
Copy link
Member

@hoxbro hoxbro commented Sep 9, 2024

Fixes #7234

Copy link

codecov bot commented Sep 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.23%. Comparing base (0453e9c) to head (eabef78).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7242   +/-   ##
=======================================
  Coverage   82.23%   82.23%           
=======================================
  Files         337      337           
  Lines       50251    50258    +7     
=======================================
+ Hits        41325    41331    +6     
- Misses       8926     8927    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hoxbro hoxbro marked this pull request as ready for review September 9, 2024 13:58
@philippjfr philippjfr merged commit 2b0b90e into main Sep 10, 2024
16 checks passed
@philippjfr philippjfr deleted the categorial_dtype_filter branch September 10, 2024 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tabulator header_filter raises: TypeError: type.__new__() takes exactly 3 arguments (1 given)
2 participants