Collection of minor fixes for Panel 1.5.1 #7285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7285 +/- ##
=======================================
Coverage 82.19% 82.20%
=======================================
Files 337 337
Lines 50394 50394
=======================================
+ Hits 41422 41426 +4
+ Misses 8972 8968 -4 ☔ View full report in Codecov by Sentry. |
hoxbro
reviewed
Sep 20, 2024
| @@ -238,7 +238,7 @@ class Serve(_BkServe): | |||
| )), | |||
| ('--autoreload', dict( | |||
| action = 'store_true', | |||
| help = "Whether to autoreload source when script changes." | |||
| help = "Whether to autoreload source when script changes. We recommend using --dev instead." | |||
There was a problem hiding this comment.
This is correct for now, but there could be a future where --dev does more than --autoreload
There was a problem hiding this comment.
Is it just for info? Or should I remove the recommendation?
|
This PR is growing. So I would like it reviewed and merged while its still possible to review. |
philippjfr
approved these changes
Sep 23, 2024
|
Happy with this, thanks! I think recommending |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--autoreloadwith--devin docs.