Timepicker: stricter parameters and minor doc changes #7308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(I would have had a small preference for allowing only a single type for |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7308 +/- ##
===========================================
+ Coverage 41.54% 82.19% +40.64%
===========================================
Files 325 337 +12
Lines 48078 50394 +2316
===========================================
+ Hits 19976 41419 +21443
+ Misses 28102 8975 -19127 ☔ View full report in Codecov by Sentry. |
philippjfr
reviewed
Sep 23, 2024
| @@ -830,7 +830,7 @@ class _TimeCommon(Widget): | |||
| selectable, and AM/PM depending on the `clock` option. | |||
| """) | |||
|
|
|||
| clock = param.String(default='12h', doc=""" | |||
There was a problem hiding this comment.
Honestly should have aligned this with DatetimePicker:
military_time = param.Boolean(default=True, doc="""
Whether to display time in 24 hour format.""")
philippjfr
approved these changes
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Funnily, I've noticed the default
clockvalue is12hin Panel and24hin Bokeh. I bet the Bokeh dev is based in Europe and the Panel dev in the US 🙃