Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address issues with Tabulator embed_content and optimize row expansion #7364

Merged
merged 10 commits into from
Oct 15, 2024

Conversation

philippjfr
Copy link
Member

  • Do not expand all rows by default if embed_content=True
  • Do not auto-reset expanded rows if embed_content
  • Ensure expanded rows are rendered efficiently

Fixes #7361

Copy link

codecov bot commented Oct 6, 2024

Codecov Report

Attention: Patch coverage is 89.28571% with 3 lines in your changes missing coverage. Please review.

Project coverage is 82.21%. Comparing base (5ef8909) to head (5bb1908).
Report is 12 commits behind head on main.

Files with missing lines Patch % Lines
panel/tests/ui/widgets/test_tabulator.py 78.57% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7364      +/-   ##
==========================================
- Coverage   82.21%   82.21%   -0.01%     
==========================================
  Files         337      337              
  Lines       50513    50545      +32     
==========================================
+ Hits        41530    41556      +26     
- Misses       8983     8989       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

panel/models/tabulator.ts Outdated Show resolved Hide resolved
@philippjfr philippjfr enabled auto-merge (squash) October 6, 2024 14:11
@hoxbro hoxbro disabled auto-merge October 7, 2024 12:31
Copy link
Member

@hoxbro hoxbro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I have added some nits comments.

panel/models/tabulator.ts Outdated Show resolved Hide resolved
panel/models/tabulator.ts Show resolved Hide resolved
philippjfr and others added 2 commits October 7, 2024 14:48
Co-authored-by: Simon Høxbro Hansen <simon.hansen@me.com>
@hoxbro
Copy link
Member

hoxbro commented Oct 8, 2024

pre-commit.ci autofix

panel/models/tabulator.ts Outdated Show resolved Hide resolved
panel/models/tabulator.ts Outdated Show resolved Hide resolved
@philippjfr philippjfr enabled auto-merge (squash) October 15, 2024 10:38
@philippjfr philippjfr merged commit 46061e6 into main Oct 15, 2024
18 checks passed
@philippjfr philippjfr deleted the tabulator_expand_regression branch October 15, 2024 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tabulator with row_content : not toggling (collapse/expand) properly
2 participants