Various fixes for custom component compilation #7381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philippjfr
commented
Oct 15, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7381 +/- ##
==========================================
+ Coverage 81.42% 82.22% +0.79%
==========================================
Files 337 337
Lines 50514 50532 +18
==========================================
+ Hits 41131 41549 +418
+ Misses 9383 8983 -400 ☔ View full report in Codecov by Sentry. |
ahuang11
pushed a commit
that referenced
this pull request
Oct 18, 2024
* Various fixes for custom component compilation * Apply suggestions from code review --------- Co-authored-by: Philipp Rudiger <philipp.rudiger@blackstone.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
npm