Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix type hint for oauth_guest_endpoints #7383

Merged
merged 2 commits into from
Oct 10, 2024

Conversation

aktech
Copy link
Contributor

@aktech aktech commented Oct 9, 2024

oauth_guest_endpoints is supposed to be a list of string instead, as can be seen in the documentation here:

panel/panel/io/server.py

Lines 899 to 900 in 7dd8908

oauth_guest_endpoints: list (optional, default=None)
List of endpoints that can be accessed as a guest without authenticating.

@aktech aktech changed the title Fix type hint for oauth_guest_endpoints Fix type hint for oauth_guest_endpoints Oct 9, 2024
Copy link

codecov bot commented Oct 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.80%. Comparing base (7dd8908) to head (a3301b3).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7383      +/-   ##
==========================================
- Coverage   82.21%   81.80%   -0.41%     
==========================================
  Files         337      337              
  Lines       50514    50514              
==========================================
- Hits        41528    41325     -203     
- Misses       8986     9189     +203     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@philippjfr philippjfr merged commit ef31354 into holoviz:main Oct 10, 2024
16 of 18 checks passed
@aktech aktech deleted the oauth-guest-endpoints branch October 10, 2024 08:19
ahuang11 pushed a commit that referenced this pull request Oct 18, 2024
* Fix type hint for oauth_guest_endpoints

* fix pre-commit
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants