Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix OAuth guest endpoint #7385

Merged
merged 1 commit into from
Oct 10, 2024
Merged

Fix OAuth guest endpoint #7385

merged 1 commit into from
Oct 10, 2024
+2 −1

Conversation

aktech
Copy link
Contributor

@aktech aktech commented Oct 9, 2024

Fixes #7384

@aktech aktech mentioned this pull request Oct 9, 2024
Closed
1 task
@codecov Codecov
Copy link

codecov bot commented Oct 9, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.20%. Comparing base (7dd8908) to head (7edcdf4).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #7385      +/-   ##
==========================================
- Coverage   82.21%   82.20%   -0.01%     
==========================================
  Files         337      337              
  Lines       50514    50514              
==========================================
- Hits        41528    41527       -1     
- Misses       8986     8987       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aktech aktech marked this pull request as ready for review October 9, 2024 17:24
philippjfr
philippjfr approved these changes Oct 10, 2024
View reviewed changes
Copy link
Member

@philippjfr philippjfr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well that's an embarrassing oversight, thanks for tracking that down!

@philippjfr philippjfr merged commit d491f91 into holoviz:main Oct 10, 2024
18 checks passed
@aktech aktech deleted the guest-endpoints branch October 10, 2024 08:20
ahuang11 pushed a commit that referenced this pull request Oct 18, 2024
@aktech @ahuang11
Fix oauth guest endpoint (#7385)
a172064
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philippjfr philippjfr philippjfr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

OAuth guest endpoints not working
2 participants
@aktech @philippjfr