-
-
Notifications
You must be signed in to change notification settings - Fork 528
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tabulator aggregators: allow nested dict, fix data aggregation #7450
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7450 +/- ##
==========================================
+ Coverage 82.08% 82.31% +0.23%
==========================================
Files 337 339 +2
Lines 50680 51090 +410
==========================================
+ Hits 41599 42054 +455
+ Misses 9081 9036 -45 ☔ View full report in Codecov by Sentry. |
Great! Some tests would be good. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@thuydotm I just pushed some minor docs changes, I think we're good on this front! I have left a few questions and suggestions for the code and tests. Pretty hard to review this as there are so many other issues with the aggregators 🙃 This first PR is almost done, we'll get there!
Co-authored-by: Maxime Liquet <35924738+maximlt@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Fixes #7281 and partially #7449
TODO:
TODO LATER in other PRs: