Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tabulator aggregators: allow nested dict, fix data aggregation #7450

Merged
merged 28 commits into from
Dec 2, 2024

Conversation

thuydotm
Copy link
Collaborator

@thuydotm thuydotm commented Oct 29, 2024

Fixes #7281 and partially #7449

TODO:

  • add tests
  • add docs for nested aggs

TODO LATER in other PRs:

  • validate input aggs?
  • for columns with no agg method, set NaNs to them? Needs a bit more experiment to see what we should do
  • display the indexes properly
  • scope out the data types to support. Handle String, Datetime, and Boolean data types?

Copy link

codecov bot commented Oct 29, 2024

Codecov Report

Attention: Patch coverage is 42.85714% with 56 lines in your changes missing coverage. Please review.

Project coverage is 82.31%. Comparing base (8dd362f) to head (4324b3b).
Report is 36 commits behind head on main.

Files with missing lines Patch % Lines
panel/tests/ui/widgets/test_tabulator.py 36.36% 56 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7450      +/-   ##
==========================================
+ Coverage   82.08%   82.31%   +0.23%     
==========================================
  Files         337      339       +2     
  Lines       50680    51090     +410     
==========================================
+ Hits        41599    42054     +455     
+ Misses       9081     9036      -45     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@philippjfr
Copy link
Member

Great! Some tests would be good.

@maximlt maximlt marked this pull request as draft October 29, 2024 12:48
@thuydotm thuydotm marked this pull request as ready for review November 11, 2024 18:36
Copy link
Member

@maximlt maximlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thuydotm I just pushed some minor docs changes, I think we're good on this front! I have left a few questions and suggestions for the code and tests. Pretty hard to review this as there are so many other issues with the aggregators 🙃 This first PR is almost done, we'll get there!

examples/reference/widgets/Tabulator.ipynb Outdated Show resolved Hide resolved
panel/tests/ui/widgets/test_tabulator.py Outdated Show resolved Hide resolved
panel/tests/ui/widgets/test_tabulator.py Outdated Show resolved Hide resolved
panel/tests/ui/widgets/test_tabulator.py Outdated Show resolved Hide resolved
panel/tests/ui/widgets/test_tabulator.py Show resolved Hide resolved
panel/tests/ui/widgets/test_tabulator.py Outdated Show resolved Hide resolved
panel/tests/ui/widgets/test_tabulator.py Outdated Show resolved Hide resolved
panel/models/tabulator.ts Outdated Show resolved Hide resolved
panel/models/tabulator.ts Outdated Show resolved Hide resolved
panel/models/tabulator.ts Show resolved Hide resolved
thuydotm and others added 2 commits November 28, 2024 21:27
Co-authored-by: Maxime Liquet <35924738+maximlt@users.noreply.github.com>
Copy link
Member

@maximlt maximlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@maximlt maximlt merged commit af3dfee into holoviz:main Dec 2, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tabulator: Separate aggregators for different columns blocked by type hint
3 participants