Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mypy issue #7512

Merged
merged 2 commits into from
Dec 3, 2024
Merged

Fix mypy issue #7512

merged 2 commits into from
Dec 3, 2024

Conversation

MarcSkovMadsen
Copy link
Collaborator

I'm currently updating and rebuilding a lot of projects. One issue I see across is that type of Tabulator.selection is not understood by mypy

error: Incompatible types in assignment (expression has type "list[int]", variable has type "_ListValidateWithCallable")  [assignment]

This PR fixes the issue.

Copy link

codecov bot commented Nov 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.22%. Comparing base (7afcc90) to head (e4cbe17).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7512   +/-   ##
=======================================
  Coverage   82.21%   82.22%           
=======================================
  Files         339      339           
  Lines       51319    51319           
=======================================
+ Hits        42193    42196    +3     
+ Misses       9126     9123    -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hoxbro
Copy link
Member

hoxbro commented Nov 22, 2024

The change looks benign. I don't understand why it is needed here and not for other parameters.

Would you happen to know why?

@hoxbro
Copy link
Member

hoxbro commented Dec 3, 2024

Would you happen to know why?

I think it is related to the param not being typed and, therefore, ignored. There is no reason not to merge this.

@philippjfr philippjfr merged commit 4e4c82b into main Dec 3, 2024
18 checks passed
@philippjfr philippjfr deleted the fix/mypy-issue branch December 3, 2024 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants