Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compat: altair 5.5.0 #7523

Merged
merged 2 commits into from
Nov 26, 2024
Merged

compat: altair 5.5.0 #7523

merged 2 commits into from
Nov 26, 2024

Conversation

hoxbro
Copy link
Member

@hoxbro hoxbro commented Nov 26, 2024

In my opinion, it isn't worth keeping a compatibility layer with try/except for docstring, so I updated it to the newest API.

@MarcSkovMadsen
Copy link
Collaborator

There is also a couple of places in the docs to fix:

image

Copy link

codecov bot commented Nov 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 41.54%. Comparing base (1f821d6) to head (19f5177).

❗ There is a different number of reports uploaded between BASE (1f821d6) and HEAD (19f5177). Click for more details.

HEAD has 8 uploads less than BASE
Flag BASE (1f821d6) HEAD (19f5177)
12 4
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #7523       +/-   ##
===========================================
- Coverage   82.38%   41.54%   -40.84%     
===========================================
  Files         339      327       -12     
  Lines       50995    48679     -2316     
===========================================
- Hits        42010    20225    -21785     
- Misses       8985    28454    +19469     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hoxbro hoxbro enabled auto-merge (squash) November 26, 2024 13:35
@hoxbro hoxbro disabled auto-merge November 26, 2024 13:35
@hoxbro hoxbro merged commit c6ac0a8 into main Nov 26, 2024
11 checks passed
@hoxbro hoxbro deleted the compat_altair branch November 26, 2024 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants