Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for remote filesystems on FileSelector #7618

Merged
merged 42 commits into from
Jan 16, 2025

Conversation

philippjfr
Copy link
Member

Since #6837 requires some more work on the tree implementation but the remote file selection pieces are well supported this PR applies the changes from that PR minus the actual tree based components.

Copy link

codecov bot commented Jan 15, 2025

Codecov Report

Attention: Patch coverage is 85.71429% with 27 lines in your changes missing coverage. Please review.

Project coverage is 86.73%. Comparing base (6c9e955) to head (63dca20).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
panel/widgets/file_selector.py 84.56% 23 Missing ⚠️
panel/tests/widgets/test_file_selector.py 94.11% 2 Missing ⚠️
panel/compiler.py 0.00% 1 Missing ⚠️
panel/util/__init__.py 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7618      +/-   ##
==========================================
+ Coverage   86.19%   86.73%   +0.53%     
==========================================
  Files         341      341              
  Lines       51661    51764     +103     
==========================================
+ Hits        44530    44898     +368     
+ Misses       7131     6866     -265     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@philippjfr philippjfr merged commit 888bdb9 into main Jan 16, 2025
16 of 18 checks passed
@philippjfr philippjfr deleted the remote_file_selector branch January 16, 2025 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants