Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only override the name of a Parameterized instance on Parameter instantiation when instantiate=True #938

Merged
merged 2 commits into from
May 15, 2024

Conversation

maximlt
Copy link
Member

@maximlt maximlt commented Apr 19, 2024

Fixes #937

Logging this change in case we agree on the suggested change in the issue.

  • Add tests

@maximlt maximlt marked this pull request as draft April 19, 2024 16:34
Copy link
Member

@philippjfr philippjfr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change makes sense to me.

@maximlt maximlt marked this pull request as ready for review May 15, 2024 14:25
@maximlt
Copy link
Member Author

maximlt commented May 15, 2024

Unrelated test failure.

@maximlt maximlt merged commit d830963 into main May 15, 2024
9 of 10 checks passed
@maximlt maximlt deleted the instantiate_override_name_only_deepcopy branch May 15, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

name of a Parameterized instance overridden when is the default of a readonly/constant Parameter
2 participants