Skip to content

Commit

Permalink
chore: [autoapprove] Pin flake8 version (googleapis#1842)
Browse files Browse the repository at this point in the history
* Update noxfile.py.j2

Pinned flake8 to the latest version (as of Aug2023) to avoid unexpected lint error after version update.

* Update .pre-commit-config.yaml
  • Loading branch information
yinghsienwu authored and holtskinner committed Aug 1, 2023
1 parent 0dd1092 commit 8e2d330
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,6 @@ repos:
hooks:
- id: black
- repo: https://github.com/pycqa/flake8
rev: 3.9.2
rev: 6.1.0
hooks:
- id: flake8
3 changes: 2 additions & 1 deletion synthtool/gcp/templates/python_library/noxfile.py.j2
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ import warnings

import nox

FLAKE8_VERSION = "flake8==6.1.0"
BLACK_VERSION = "black[jupyter]==23.7.0"
ISORT_VERSION = "isort==5.11.0"
LINT_PATHS = ["docs", "google", "tests", "noxfile.py", "setup.py"]
Expand Down Expand Up @@ -152,7 +153,7 @@ def lint(session):
Returns a failure if the linters find linting errors or sufficiently
serious code quality issues.
"""
session.install("flake8", BLACK_VERSION)
session.install(FLAKE8_VERSION, BLACK_VERSION)
session.run(
"black",
"--check",
Expand Down

0 comments on commit 8e2d330

Please sign in to comment.