Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pyproject.toml #74

Merged
merged 1 commit into from
Mar 26, 2024
Merged

Update pyproject.toml #74

merged 1 commit into from
Mar 26, 2024

Conversation

inkenbrandt
Copy link
Contributor

@inkenbrandt inkenbrandt commented Mar 23, 2024

Please use the inequality syntax >= instead of caret syntax ^, which is Poetry's default version capping. Unfortunately, version capping is restrictive, and it is preventing compatibility in the conda installations. The limitations caused by capping are detailed Henry Schreiner's blog post on poetry's decisions on capping.

Poetry's default version capping is restrictive and unnecessary. 
 It is preventing compatibility in the conda installations.  The limitations caused by capping are detailed Henry Schreiner's blog post on poetry's decisions on capping (https://iscinumpy.dev/post/bound-version-constraints/).  

Setting a minimum version is better than a minimum version with a cap.
@inkenbrandt
Copy link
Contributor Author

Related to #59

@inkenbrandt
Copy link
Contributor Author

@holukas
Copy link
Owner

holukas commented Mar 26, 2024

Thanks for the links, I will add this to main. From what I see (so far) there is no downside in using >=.

@holukas holukas merged commit 7861b6a into holukas:main Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants