Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve ping performance #1020

Merged
merged 1 commit into from
Aug 24, 2024
Merged

fix: improve ping performance #1020

merged 1 commit into from
Aug 24, 2024

Conversation

Meierschlumpf
Copy link
Member


Homarr

Thank you for your contribution. Please ensure that your pull request meets the following pull request:

  • Builds without warnings or errors (pnpm buid, autofix with pnpm format:fix)
  • Pull request targets dev branch
  • Commits follow the conventional commits guideline
  • No shorthand variable names are used (eg. x, y, i or any abbrevation)

This fixes that it waits for each timeout of those fetches which can result in times higher than the ping cycle of one minute. All pings should be done after less than 15 seconds.

@Meierschlumpf Meierschlumpf added the bug Something isn't working label Aug 23, 2024
@Meierschlumpf Meierschlumpf added this to the 1.0.0-alpha.1 milestone Aug 23, 2024
@Meierschlumpf Meierschlumpf self-assigned this Aug 23, 2024
@Meierschlumpf Meierschlumpf requested a review from a team as a code owner August 23, 2024 20:11
Copy link

deepsource-io bot commented Aug 23, 2024

Here's the code health analysis summary for commits cbf2ecf..601ea07. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource JavaScript LogoJavaScript✅ SuccessView Check ↗

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

Copy link

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 40.47% 11490 / 28388
🔵 Statements 40.47% 11490 / 28388
🔵 Functions 37.7% 282 / 748
🔵 Branches 71.68% 1076 / 1501
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
packages/cron-jobs/src/jobs/ping.ts 0% 0% 0% 0% 1-4, 6, 8-11, 13-16, 18-19, 21-22, 24-28, 30-34
Generated in workflow #2659

@Meierschlumpf Meierschlumpf merged commit b81f5a2 into dev Aug 24, 2024
11 checks passed
@Meierschlumpf Meierschlumpf deleted the improve-ping-performance branch August 24, 2024 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants