Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: sonarr testConnectionAsync url #1024

Merged
merged 1 commit into from
Aug 25, 2024
Merged

fix: sonarr testConnectionAsync url #1024

merged 1 commit into from
Aug 25, 2024

Conversation

hillaliy
Copy link
Contributor

@hillaliy hillaliy commented Aug 24, 2024 •
edited
Loading


Homarr

Thank you for your contribution. Please ensure that your pull request meets the following pull request:

  • Builds without warnings or errors (pnpm buid, autofix with pnpm format:fix)
  • Pull request targets dev branch
  • Commits follow the conventional commits guideline
  • No shorthand variable names are used (eg. x, y, i or any abbrevation)

@hillaliy hillaliy requested a review from a team as a code owner August 24, 2024 19:04
@deepsource-io deepsource.io
Copy link

deepsource-io bot commented Aug 24, 2024

Here's the code health analysis summary for commits ec2de90..d4e0947. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource JavaScript LogoJavaScript✅ SuccessView Check ↗
💡 If you’re a repository administrator, you can configure the quality gates from the settings.

@hillaliy hillaliy added the bug Something isn't working label Aug 24, 2024
@hillaliy hillaliy self-assigned this Aug 24, 2024
@github-actions GitHub Actions
Copy link

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 39.87% 11654 / 29228
🔵 Statements 39.87% 11654 / 29228
🔵 Functions 36.91% 282 / 764
🔵 Branches 71.36% 1079 / 1512
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
packages/integrations/src/media-organizer/sonarr/sonarr-integration.ts 21.62% 100% 0% 21.62% 13-19, 27-41, 43-58, 60-70, 72-80, 82-83, 85-88, 90-95, 97-103, 105-114
Generated in workflow #2675

SeDemal
SeDemal approved these changes Aug 25, 2024
View reviewed changes
Copy link
Collaborator

@SeDemal SeDemal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@SeDemal SeDemal changed the title fix: testConnectionAsync url fix: sonarr testConnectionAsync url Aug 25, 2024
@hillaliy hillaliy merged commit e34af86 into dev Aug 25, 2024
15 checks passed
@hillaliy hillaliy deleted the fix--sonarr-integration-connextion-test branch August 25, 2024 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SeDemal SeDemal SeDemal approved these changes

Assignees

@hillaliy hillaliy

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hillaliy @SeDemal