Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: when removing one item and then adding another one that newly added one can not be moved #1025

Merged
merged 4 commits into from
Aug 29, 2024

Conversation

Meierschlumpf
Copy link
Member


Homarr

Thank you for your contribution. Please ensure that your pull request meets the following pull request:

  • Builds without warnings or errors (pnpm buid, autofix with pnpm format:fix)
  • Pull request targets dev branch
  • Commits follow the conventional commits guideline
  • No shorthand variable names are used (eg. x, y, i or any abbrevation)

Should resolve report on discord

@Meierschlumpf Meierschlumpf added the bug Something isn't working label Aug 25, 2024
@Meierschlumpf Meierschlumpf added this to the 1.0.0-alpha.1 milestone Aug 25, 2024
@Meierschlumpf Meierschlumpf self-assigned this Aug 25, 2024
@Meierschlumpf Meierschlumpf requested a review from a team as a code owner August 25, 2024 08:25
Copy link

deepsource-io bot commented Aug 25, 2024

Here's the code health analysis summary for commits c7a7cef..3e4b3ea. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource JavaScript LogoJavaScript✅ SuccessView Check ↗

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

Copy link

github-actions bot commented Aug 25, 2024

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 39.79% 11676 / 29337
🔵 Statements 39.79% 11676 / 29337
🔵 Functions 36.71% 282 / 768
🔵 Branches 71.17% 1079 / 1516
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
apps/nextjs/src/components/board/sections/gridstack/use-gridstack.ts 0% 0% 0% 0% 1-3, 8-11, 32-40, 42-45, 47-49, 51-52, 54-58, 61, 63, 65, 67, 69-72, 74-81, 83, 85, 88-96, 99-101, 103-106, 108, 110, 112-113, 117, 119, 121, 123-126, 128-130, 134, 136, 138, 140-143, 145-152, 154, 156, 158-160, 164, 166, 168, 170-173, 175-178, 182, 184, 186, 188-191, 193-196, 198-200, 202-203, 206-209, 211, 213-221, 224-226, 228-232, 235-245, 249-251, 254, 256, 259-262, 264-271, 292-310, 312-314, 316-317, 319-322, 324-325, 328-339, 342-344, 347-350
Generated in workflow #2712

@Meierschlumpf Meierschlumpf merged commit 2738f40 into dev Aug 29, 2024
10 checks passed
@Meierschlumpf Meierschlumpf deleted the fix-items-not-movable-after-remove-and-add branch August 29, 2024 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants