Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: websocket url is always localhost #1072

Merged
merged 1 commit into from
Sep 6, 2024

Conversation

Meierschlumpf
Copy link
Member


Homarr

Thank you for your contribution. Please ensure that your pull request meets the following pull request:

  • Builds without warnings or errors (pnpm buid, autofix with pnpm format:fix)
  • Pull request targets dev branch
  • Commits follow the conventional commits guideline
  • No shorthand variable names are used (eg. x, y, i or any abbrevation)

@Meierschlumpf Meierschlumpf added the bug Something isn't working label Sep 6, 2024
@Meierschlumpf Meierschlumpf self-assigned this Sep 6, 2024
@Meierschlumpf Meierschlumpf requested a review from a team as a code owner September 6, 2024 14:46
@Meierschlumpf Meierschlumpf changed the title fix: wevbsocket url is always localhost fix: websocket url is always localhost Sep 6, 2024
Copy link

deepsource-io bot commented Sep 6, 2024

Here's the code health analysis summary for commits 753d091..48e8bcf. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource JavaScript LogoJavaScript✅ Success
🎯 2 occurences resolved
View Check ↗

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

Copy link

github-actions bot commented Sep 6, 2024

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 39.75% 11755 / 29571
🔵 Statements 39.75% 11755 / 29571
🔵 Functions 36.56% 283 / 774
🔵 Branches 71.09% 1080 / 1519
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
apps/nextjs/src/app/[locale]/_client-providers/trpc.tsx 0% 0% 0% 0% 1, 4-9, 12, 14-16, 18-28, 30-46, 48-61, 63-69, 71, 73-77
apps/nextjs/src/app/[locale]/manage/tools/logs/client.tsx 0% 0% 0% 0% 1, 3, 5-10
apps/nextjs/src/app/[locale]/manage/tools/logs/page.tsx 0% 0% 0% 0% 1, 3, 5, 7-10, 12-13, 15-18, 20-27, 29
apps/nextjs/src/app/[locale]/manage/tools/logs/terminal.tsx 0% 0% 0% 0% 1, 3-7, 9, 11, 13-14, 16-22, 24-26, 28-31, 33, 35-41, 45-49, 51-57
Generated in workflow #2779

@Meierschlumpf Meierschlumpf merged commit 8c20553 into dev Sep 6, 2024
11 checks passed
@Meierschlumpf Meierschlumpf deleted the fix-websocket-url-always-localhost branch September 6, 2024 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants