Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: hard to move iframe widget #1075 #1101

Merged
merged 1 commit into from
Sep 11, 2024
Merged

fix: hard to move iframe widget #1075 #1101

merged 1 commit into from
Sep 11, 2024

Conversation

Meierschlumpf
Copy link
Member

@Meierschlumpf Meierschlumpf commented Sep 11, 2024


Homarr

Thank you for your contribution. Please ensure that your pull request meets the following pull request:

  • Builds without warnings or errors (pnpm buid, autofix with pnpm format:fix)
  • Pull request targets dev branch
  • Commits follow the conventional commits guideline
  • No shorthand variable names are used (eg. x, y, i or any abbrevation)

Now the iframe can be moved in edit mode as the user wants, the content can not be interacted with during edit mode.
Closes #1075

@Meierschlumpf Meierschlumpf added the bug Something isn't working label Sep 11, 2024
@Meierschlumpf Meierschlumpf self-assigned this Sep 11, 2024
@Meierschlumpf Meierschlumpf requested a review from a team as a code owner September 11, 2024 14:10
Copy link

deepsource-io bot commented Sep 11, 2024

Here's the code health analysis summary for commits 3d4e607..1dddfe7. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource JavaScript LogoJavaScript✅ Success
🎯 3 occurences resolved
View Check ↗

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

Copy link

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 39.44% 12357 / 31327
🔵 Statements 39.44% 12357 / 31327
🔵 Functions 35.11% 308 / 877
🔵 Branches 71.11% 1108 / 1558
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
packages/widgets/src/iframe/component.tsx 0% 0% 0% 0% 1-2, 4-5, 8, 10-13, 15, 17-24, 26-28, 30, 32-33, 35-39, 41, 43-47, 49-58
Generated in workflow #2842

@SeDemal SeDemal merged commit 5e77221 into dev Sep 11, 2024
15 checks passed
@SeDemal SeDemal deleted the fix-iframe-move-issue branch September 11, 2024 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: iframe should have a border
2 participants