Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Remove typed-rpc dependency and used fetch instead #1108

Merged
merged 3 commits into from
Sep 16, 2024

Conversation

SeDemal
Copy link
Collaborator

@SeDemal SeDemal commented Sep 11, 2024

Fetch method POST achieves basically the same as typed-rpc.
Could actually use all that was already made and just swap it.
Allows to remove a dependency.

Closes #1104
To delete once merged

@SeDemal SeDemal requested a review from a team as a code owner September 11, 2024 21:46
Copy link

deepsource-io bot commented Sep 11, 2024

Here's the code health analysis summary for commits aca5c27..4d31002. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource JavaScript LogoJavaScript✅ SuccessView Check ↗

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

Copy link

github-actions bot commented Sep 11, 2024

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 39.65% 13257 / 33432
🔵 Statements 39.65% 13257 / 33432
🔵 Functions 36.54% 360 / 985
🔵 Branches 71.66% 1209 / 1687
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
packages/integrations/src/download-client/nzbget/nzbget-integration.ts 75.2% 78.26% 70% 75.2% 45-57, 68-69, 76-77, 85, 110-111, 120, 127-135
packages/integrations/test/nzbget.spec.ts 98.42% 95.65% 100% 98.42% 194-195
packages/widgets/src/downloads/component.tsx 0% 0% 0% 0% 1, 3, 5, 23-24, 35-36, 38, 40-42, 44, 50, 53, 56-74, 76-79, 81-84, 86, 88-97, 99, 105-108, 111-120, 123-124, 127-128, 131-133, 136-141, 143, 145-148, 150-151, 153-154, 156-157, 159-160, 162-166, 169-171, 173, 175-178, 180, 182-189, 191-199, 201-209, 211-220, 222-224, 227-234, 236-269, 272-274, 277-295, 298-301, 304-306, 309-320, 323-327, 331-353, 356-364, 366-371, 373, 375-389, 391-399, 401-408, 410-412, 414-433, 436-454, 456-472, 474-483, 485-505, 507-571, 574-603, 605-635, 637, 640-650, 652-654, 656-660, 664-674, 676-680, 682-685, 687, 696-701, 703-706, 708-740, 742, 744, 746-749, 752-766, 768-774, 776, 778, 780, 787-821, 823-825, 827-834, 836-845, 847-849, 851-884, 886-888, 890-906, 908-910, 912-914, 916-921, 923
Generated in workflow #2888

@Meierschlumpf Meierschlumpf changed the title feat: Remove typed-rpc dependency and used fetch instead refactor: Remove typed-rpc dependency and used fetch instead Sep 13, 2024
@Meierschlumpf Meierschlumpf merged commit b9206d3 into dev Sep 16, 2024
10 checks passed
@Meierschlumpf Meierschlumpf deleted the nzbget-remove-typed-rpc branch September 16, 2024 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants