Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Simple-Icons and Selfh.st collections #1118

Merged
merged 2 commits into from
Sep 16, 2024

Conversation

SeDemal
Copy link
Collaborator

@SeDemal SeDemal commented Sep 12, 2024

Closes #1105

Add Simple-Icons:

Monochrome Icons.
Can change color by adding "/{colour}" at the end of the link, can also be in hex format.

Add Selfh.st icons:

Self-hosting focused collection.
Completes current collections with icons that are not available from other sources.

Refactor:

Change regex function (Wrongly named too btw) with path parse.
Add blob replace: "{1}" -> icon name only and not whole path.
Improve file extension checker

This pushes us over the 10k icons

refactor: icon file path parsing
@SeDemal SeDemal requested a review from a team as a code owner September 12, 2024 20:55
@SeDemal SeDemal force-pushed the feat/add-new-icons-fetcher-collections branch from e734cae to 123a8f8 Compare September 12, 2024 20:56
Copy link

deepsource-io bot commented Sep 12, 2024

Here's the code health analysis summary for commits 2351617..212897a. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource JavaScript LogoJavaScript✅ Success
🎯 5 occurences resolved
View Check ↗

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

Copy link

github-actions bot commented Sep 12, 2024

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 39.61% 13247 / 33438
🔵 Statements 39.61% 13247 / 33438
🔵 Functions 36.54% 360 / 985
🔵 Branches 71.62% 1204 / 1681
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
packages/icons/src/icons-fetcher.ts 0% 0% 0% 0% 1-2, 5-46, 48-50
packages/icons/src/repositories/github.icon-repository.ts 0% 0% 0% 0% 1, 3, 7, 9-19, 21-24, 26-27, 29-38, 40-41, 43-54
packages/icons/src/repositories/icon-repository.ts 0% 0% 0% 0% 1, 6-7, 9-16, 18-29, 32
packages/icons/src/repositories/jsdelivr.icon-repository.ts 0% 0% 0% 0% 1, 3, 7, 9-19, 21-23, 25-33, 35-46
packages/icons/src/types/icon-repository-license.ts 0% 0% 0% 0%
Generated in workflow #2871

@SeDemal SeDemal force-pushed the feat/add-new-icons-fetcher-collections branch from f4f8104 to 212897a Compare September 12, 2024 21:46
@SeDemal SeDemal merged commit 9fb6e67 into dev Sep 16, 2024
12 checks passed
@SeDemal SeDemal deleted the feat/add-new-icons-fetcher-collections branch September 16, 2024 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: New icon repos
2 participants