Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: node cache cleanup error #1124

Merged
merged 1 commit into from
Sep 14, 2024
Merged

Conversation

manuel-rw
Copy link
Member


Homarr

Thank you for your contribution. Please ensure that your pull request meets the following pull request:

  • Builds without warnings or errors (pnpm buid, autofix with pnpm format:fix)
  • Pull request targets dev branch
  • Commits follow the conventional commits guideline
  • No shorthand variable names are used (eg. x, y, i or any abbrevation)

Caching pnpm dependencies is harder because we install & build within the docker builder.
See actions/setup-node#801 (comment) and https://dev.to/henryjw/caching-pnpm-modules-in-docker-builds-in-github-actions-mj7 for further information. The benefit with caching dependencies likely won't be huge -> therefore I suggest disabling caching here until we run into performance problems with the actions - then we can act again.

@manuel-rw manuel-rw requested a review from a team as a code owner September 14, 2024 08:23
@manuel-rw manuel-rw self-assigned this Sep 14, 2024
@manuel-rw manuel-rw added the enhancement New feature or request label Sep 14, 2024
Copy link

deepsource-io bot commented Sep 14, 2024

Here's the code health analysis summary for commits c8dfbc8..b9bdee6. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource JavaScript LogoJavaScript✅ SuccessView Check ↗

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

Copy link

github-actions bot commented Sep 14, 2024

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 39.61% 13240 / 33418
🔵 Statements 39.61% 13240 / 33418
🔵 Functions 36.54% 360 / 985
🔵 Branches 71.42% 1202 / 1683
File CoverageNo changed files found.
Generated in workflow #2879

@manuel-rw manuel-rw merged commit 16a5b43 into dev Sep 14, 2024
9 of 10 checks passed
@Meierschlumpf Meierschlumpf deleted the config/node-cache-cleanup-error branch September 17, 2024 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants