Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: OMV integration & health monitoring widget #1142
base: dev
Are you sure you want to change the base?
feat: OMV integration & health monitoring widget #1142
Changes from all commits
2c34c1d
d1d3180
5fdf3da
3c9f78b
9fd8e16
062c867
50e478b
7780cb7
b422924
710ea95
b0c9b1e
aa84936
846ba93
d1a40d6
dcde76f
01d7bd0
7543f14
262bb18
12ccb33
8391e75
15e7119
04e78ad
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it really required to call this function every request?
You will create double the noise for every API call. It isn't a bad thing but would be nice to avoid unnessesary network traffic if possible. Does the Cookie have an expiry?
If yes, maybe you can only perform this logic if the Cookie expired or will expire soon?
@Meierschlumpf I think your guidance would be nice here. Would a cache make sense here? And if yes, how do we deal with integration updates (eg. change URL)?