Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: insert limit of sqlite is smaller than amount of icons #1161

Merged
merged 1 commit into from
Sep 21, 2024

Conversation

Meierschlumpf
Copy link
Member


Homarr

Thank you for your contribution. Please ensure that your pull request meets the following pull request:

  • Builds without warnings or errors (pnpm buid, autofix with pnpm format:fix)
  • Pull request targets dev branch
  • Commits follow the conventional commits guideline
  • No shorthand variable names are used (eg. x, y, i or any abbrevation)

@Meierschlumpf Meierschlumpf added the bug Something isn't working label Sep 21, 2024
@Meierschlumpf Meierschlumpf self-assigned this Sep 21, 2024
@Meierschlumpf Meierschlumpf marked this pull request as ready for review September 21, 2024 09:04
@Meierschlumpf Meierschlumpf requested a review from a team as a code owner September 21, 2024 09:04
Copy link

deepsource-io bot commented Sep 21, 2024

Here's the code health analysis summary for commits 612a158..1036c37. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource JavaScript LogoJavaScript✅ SuccessView Check ↗

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

Copy link

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 39.25% 13623 / 34702
🔵 Statements 39.25% 13623 / 34702
🔵 Functions 35.56% 361 / 1015
🔵 Branches 70.49% 1221 / 1732
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
packages/cron-jobs/src/jobs/icons-updater.ts 0% 0% 0% 0% 1-2, 4-8, 10, 12-23, 25-29, 31-33, 35-36, 38-39, 41-44, 46-53, 55-59, 61-70, 72-74, 76-79, 81, 83-94, 96-97, 99-100
Generated in workflow #2987

@Meierschlumpf Meierschlumpf merged commit 9eea8d4 into dev Sep 21, 2024
10 checks passed
@Meierschlumpf Meierschlumpf deleted the fix-icons-updater-sqlite-insert-limit branch September 21, 2024 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants