Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: replace custom no integration selected logic with existing … #1166

Merged
merged 1 commit into from
Sep 23, 2024

Conversation

Meierschlumpf
Copy link
Member

…error


Homarr

Thank you for your contribution. Please ensure that your pull request meets the following pull request:

  • Builds without warnings or errors (pnpm buid, autofix with pnpm format:fix)
  • Pull request targets dev branch
  • Commits follow the conventional commits guideline
  • No shorthand variable names are used (eg. x, y, i or any abbrevation)

Closes #1076

image
image

@Meierschlumpf Meierschlumpf self-assigned this Sep 23, 2024
@Meierschlumpf Meierschlumpf requested a review from a team as a code owner September 23, 2024 19:06
Copy link

deepsource-io bot commented Sep 23, 2024

Here's the code health analysis summary for commits 6aa5adf..f4d07bd. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource JavaScript LogoJavaScript✅ SuccessView Check ↗

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

Copy link

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 39.24% 13620 / 34708
🔵 Statements 39.24% 13620 / 34708
🔵 Functions 35.53% 361 / 1016
🔵 Branches 70.42% 1219 / 1731
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
packages/translation/src/lang/en.ts 100% 100% 100% 100%
packages/widgets/src/errors/no-data-integration.tsx 0% 0% 0% 0% 1, 5, 7-10, 12-19
packages/widgets/src/media-requests/list/component.tsx 0% 0% 0% 0% 1-3, 5-6, 8, 11-12, 14-25, 27-36, 38-54, 56, 58, 60, 62-66, 68-76, 78-88, 90-96, 98-119, 121-130, 132-150, 152-169, 171-186, 188-191, 193-198, 200, 202-218
packages/widgets/src/media-requests/stats/component.tsx 0% 0% 0% 0% 1-3, 15-16, 18, 20, 23-25, 27-38, 40-49, 51, 53-56, 58-67, 69, 71, 74-115, 117-125, 127-139, 141-162, 164-175, 177-202, 204-210, 212
Generated in workflow #3005

@Meierschlumpf Meierschlumpf merged commit cc29cb8 into dev Sep 23, 2024
10 checks passed
@Meierschlumpf Meierschlumpf deleted the refactor-1076-media-request-integration-errors branch September 23, 2024 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: media request list shows custom integration error
2 participants