Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: issue with color scheme in layout #1168

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

Meierschlumpf
Copy link
Member

@Meierschlumpf Meierschlumpf commented Sep 23, 2024


Homarr

Thank you for your contribution. Please ensure that your pull request meets the following pull request:

  • Builds without warnings or errors (pnpm buid, autofix with pnpm format:fix)
  • Pull request targets dev branch
  • Commits follow the conventional commits guideline
  • No shorthand variable names are used (eg. x, y, i or any abbrevation)

This fixes the bug that sometimes the whole screen is black and there are no colors. The reason was, that we only used the color scheme when signed in and otherwise it was not set. Now I use a cookie and when you log in it's set to that one saved for the specific user

@Meierschlumpf Meierschlumpf added the bug Something isn't working label Sep 23, 2024
@Meierschlumpf Meierschlumpf self-assigned this Sep 23, 2024
@Meierschlumpf Meierschlumpf requested a review from a team as a code owner September 23, 2024 20:44
Copy link

deepsource-io bot commented Sep 23, 2024

Here's the code health analysis summary for commits 6aa5adf..0a5ed13. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource JavaScript LogoJavaScript✅ SuccessView Check ↗

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

Copy link

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 39.24% 13626 / 34724
🔵 Statements 39.24% 13626 / 34724
🔵 Functions 35.53% 361 / 1016
🔵 Branches 70.69% 1228 / 1737
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
apps/nextjs/src/app/[locale]/layout.tsx 0% 0% 0% 0% 1-2, 4-7, 9, 11-14, 16-23, 25-28, 30-47, 49-54, 56-58, 60-69, 71, 73-84, 86
apps/nextjs/src/app/[locale]/_client-providers/mantine.tsx 0% 0% 0% 0% 1, 4, 6-7, 9-11, 13-14, 16-23, 25-26, 28, 30-40, 42, 44-48, 50-52, 54-60, 62-72, 74-80, 82-83, 85-87, 89-93
packages/auth/callbacks.ts 90.78% 92.85% 100% 90.78% 89, 92-95, 97-98
packages/common/src/cookie.ts 20% 100% 0% 20% 5-7, 9-17, 19-20, 23-24
Generated in workflow #3007

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant