Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add million-lint #607

Merged
merged 8 commits into from
Aug 29, 2024
Merged

feat: add million-lint #607

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
1849407
feat: Add `million-lint`
ajnart Jun 2, 2024
c974e0c
Merge branch 'dev' into ajnart/feat-million-lint
Meierschlumpf Aug 24, 2024
464c061
fix: some parts not working because of missing skipTransform flag
Meierschlumpf Aug 24, 2024
a93ca67
chore: address pull request feedback
Meierschlumpf Aug 24, 2024
e3c380d
chore: make with-million-lint method that can be used when debugging …
Meierschlumpf Aug 24, 2024
e80885a
fix: format issue
Meierschlumpf Aug 24, 2024
62b0b95
Merge branch 'dev' into ajnart/feat-million-lint
Meierschlumpf Aug 29, 2024
a95dc45
fix: format issue
Meierschlumpf Aug 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,4 +54,5 @@ yarn-error.log*
*.log

apps/tasks/tasks.cjs
apps/websocket/wssServer.cjs
apps/websocket/wssServer.cjs
apps/nextjs/.million/
3 changes: 2 additions & 1 deletion .vscode/extensions.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
"recommendations": [
"dbaeumer.vscode-eslint",
"esbenp.prettier-vscode",
"yoavbls.pretty-ts-errors"
"yoavbls.pretty-ts-errors",
"million.million-lint"
]
}
6 changes: 6 additions & 0 deletions apps/nextjs/next.config.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
// Importing env files here to validate on build
import "@homarr/auth/env.mjs";

import MillionLint from "@million/lint";

import "./src/env.mjs";

/** @type {import("next").NextConfig} */
Expand Down Expand Up @@ -28,4 +31,7 @@ const config = {
},
};

// Skip transform is used because of webpack loader, without it for example 'Tooltip.Floating' will not work and show an error
const withMillionLint = MillionLint.next({ rsc: true, skipTransform: true, telemetry: false });

export default config;
3 changes: 2 additions & 1 deletion apps/nextjs/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@
"@homarr/log": "workspace:^",
"@homarr/modals": "workspace:^0.1.0",
"@homarr/notifications": "workspace:^0.1.0",
"@homarr/server-settings": "workspace:^0.1.0",
"@homarr/spotlight": "workspace:^0.1.0",
"@homarr/translation": "workspace:^0.1.0",
"@homarr/ui": "workspace:^0.1.0",
Expand All @@ -37,7 +38,7 @@
"@mantine/hooks": "^7.12.1",
"@mantine/modals": "^7.12.1",
"@mantine/tiptap": "^7.12.1",
"@homarr/server-settings": "workspace:^0.1.0",
"@million/lint": "1.0.0-rc.84",
"@t3-oss/env-nextjs": "^0.11.0",
"@tanstack/react-query": "^5.52.1",
"@tanstack/react-query-devtools": "^5.52.1",
Expand Down
Loading