Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add pi-hole test container integration test #649

Merged
merged 5 commits into from
Jun 10, 2024
Merged

test: add pi-hole test container integration test #649

merged 5 commits into from
Jun 10, 2024

Conversation

Meierschlumpf
Copy link
Member

@Meierschlumpf Meierschlumpf commented Jun 9, 2024 •
edited
Loading


Homarr

Thank you for your contribution. Please ensure that your pull request meets the following pull request:

  • Builds without warnings or errors (pnpm buid, autofix with pnpm format:fix)
  • Pull request targets dev branch
  • Commits follow the conventional commits guideline
  • No shorthand variable names are used (eg. x, y, i or any abbrevation)

@Meierschlumpf Meierschlumpf self-assigned this Jun 9, 2024
@Meierschlumpf Meierschlumpf requested a review from a team as a code owner June 9, 2024 20:28
manuel-rw
manuel-rw requested changes Jun 9, 2024
View reviewed changes
packages/integrations/test/pi-hole.spec.ts Outdated Show resolved Hide resolved
packages/integrations/test/pi-hole.spec.ts Show resolved Hide resolved
packages/integrations/test/pi-hole.spec.ts Outdated Show resolved Hide resolved
packages/integrations/test/pi-hole.spec.ts Outdated Show resolved Hide resolved
@manuel-rw manuel-rw merged commit c627384 into dev Jun 10, 2024
10 checks passed
@manuel-rw manuel-rw deleted the test-container-pi-hole branch June 10, 2024 19:18
@github-actions github-actions bot mentioned this pull request Jun 14, 2024
Closed
This was referenced Jun 28, 2024
Closed
Closed
@github-actions github-actions bot mentioned this pull request Jul 12, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manuel-rw manuel-rw manuel-rw approved these changes

Assignees

@Meierschlumpf Meierschlumpf

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Meierschlumpf @manuel-rw