Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add undici fetch interceptor #687

Merged
merged 1 commit into from
Jun 19, 2024
Merged

feat: add undici fetch interceptor #687

merged 1 commit into from
Jun 19, 2024

Conversation

manuel-rw
Copy link
Member

@manuel-rw manuel-rw commented Jun 18, 2024 •
edited
Loading


Homarr

Thank you for your contribution. Please ensure that your pull request meets the following pull request:

  • Builds without warnings or errors (pnpm buid, autofix with pnpm format:fix)
  • Pull request targets dev branch
  • Commits follow the conventional commits guideline
  • No shorthand variable names are used (eg. x, y, i or any abbrevation)

image

All credit goes to Meier- I only adjusted the format & logging

@manuel-rw manuel-rw self-assigned this Jun 18, 2024
@manuel-rw manuel-rw marked this pull request as ready for review June 18, 2024 19:46
@manuel-rw manuel-rw requested a review from a team as a code owner June 18, 2024 19:46
@manuel-rw manuel-rw added the enhancement New feature or request label Jun 18, 2024
Meierschlumpf
Meierschlumpf approved these changes Jun 18, 2024
View reviewed changes
Copy link
Member

@Meierschlumpf Meierschlumpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe debug log level makes more sense so the logs are not spammed

@manuel-rw
Copy link
Member Author

IMO info is fine here because...

  • most people will not know how to change the log level
  • network requests are crucial information
  • we don't perform thousands of requests. The noise from Nextjs will be more than this one.
    However, I'm open to discussions and we can easily change this in a future commit. I'll merge it for now so we can make use of it while developing.

@manuel-rw manuel-rw merged commit 508369c into dev Jun 19, 2024
10 checks passed
@manuel-rw manuel-rw deleted the global-undici-interceptor branch June 19, 2024 17:26
This was referenced Jun 28, 2024
Closed
Closed
@github-actions github-actions bot mentioned this pull request Jul 12, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Meierschlumpf Meierschlumpf Meierschlumpf approved these changes

Assignees

@manuel-rw manuel-rw

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@manuel-rw @Meierschlumpf