Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: DnsHole controls timer #953

Merged
merged 5 commits into from
Aug 28, 2024
Merged

fix: DnsHole controls timer #953

merged 5 commits into from
Aug 28, 2024

Conversation

hillaliy
Copy link
Contributor

@hillaliy hillaliy commented Aug 9, 2024


Homarr

Thank you for your contribution. Please ensure that your pull request meets the following pull request:

  • Builds without warnings or errors (pnpm buid, autofix with pnpm format:fix)
  • Pull request targets dev branch
  • Commits follow the conventional commits guideline
  • No shorthand variable names are used (eg. x, y, i or any abbrevation)

@hillaliy hillaliy requested a review from a team as a code owner August 9, 2024 12:29
Copy link

deepsource-io bot commented Aug 9, 2024

Here's the code health analysis summary for commits 21c0e4b..6d04ee1. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource JavaScript LogoJavaScript✅ Success
🎯 2 occurences resolved
View Check ↗

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

Copy link

github-actions bot commented Aug 9, 2024

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 40.42% 11440 / 28296
🔵 Statements 40.42% 11440 / 28296
🔵 Functions 37.83% 280 / 740
🔵 Branches 71.59% 1071 / 1496
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
packages/integrations/src/adguard-home/adguard-home-integration.ts 7.51% 100% 0% 7.51% 9-13, 15-19, 21-25, 27-31, 33-37, 39-43, 45-47, 49-63, 65-75, 77-84, 87-101, 103-106, 109-124, 127-143, 146-149
packages/widgets/src/dns-hole/controls/TimerModal.tsx 0% 0% 0% 0% 1, 3-4, 6, 15-20, 22-30, 32-44, 46-50, 52-63, 65-69, 71-82, 84-96, 98-101, 103, 105
packages/widgets/src/dns-hole/controls/component.tsx 0% 0% 0% 0% 1, 3-6, 8-9, 11, 14-15, 17, 19-28, 30-38, 40-46, 48-69, 71-74, 76-87, 89-91, 93-103, 105-107, 109-116, 118-121, 124-137, 139-145, 147, 159-170, 172-195, 197-202, 204
Generated in workflow #2616

@hillaliy
Copy link
Contributor Author

I think it's can be merge

manuel-rw
manuel-rw previously approved these changes Aug 15, 2024
Copy link
Member

@manuel-rw manuel-rw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please wait for a second approval

packages/widgets/src/dns-hole/controls/component.tsx Outdated Show resolved Hide resolved
packages/widgets/src/dns-hole/controls/component.tsx Outdated Show resolved Hide resolved
Copy link
Member

@Meierschlumpf Meierschlumpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now look good to me

@manuel-rw manuel-rw requested a review from SeDemal August 25, 2024 16:07
@hillaliy hillaliy merged commit 69e69ee into dev Aug 28, 2024
10 checks passed
@hillaliy hillaliy deleted the fix-DnsHole-controls-timer branch August 28, 2024 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants