Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add helios_vallox_ventilation #6213

Conversation

Tom-Bom-badil
Copy link

@Tom-Bom-badil Tom-Bom-badil commented Dec 13, 2024

Adding a brand for the Helios/Vallox RS485-based energy recovery ventilation systems.

I am alpha-testing my corresponding custom integration since two weeks now, public beta on Github before end of the year.

To be made available through HACS after public beta. Just making sure everything is ready when beta starts, including logo.

Type of change

  • Add a new logo or icon for a new core integration
  • Add a missing icon or logo for an existing core integration
  • Add a new logo or icon for a custom integration (custom component)
  • Replace an existing icon or logo with a higher quality version
  • Replace an existing icon or logo after a branding change
  • Removing an icon or logo

Additional information

  • This PR fixes or closes issue: fixes #
  • Link to code base pull request:
  • Link to documentation pull request:
  • Link to integration documentation on our website:
  • Link to custom integration repository:

Checklist

  • The added/replaced image(s) are PNG
  • Icon image size is 256x256px (icon.png)
  • hDPI icon image size is 512x512px for (icon@2x.png)
  • Logo image size has min 128px, but max 256px, on the shortest side (logo.png)
  • hDPI logo image size has min 256px, but max 512px, on the shortest side (logo@2x.png)

Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there @Tom-Bom-badil 👋

I could not find the public repository providing these custom integration. Could you please point me to it?

Thanks! 👍

../Frenck

@home-assistant home-assistant bot marked this pull request as draft December 13, 2024 14:27
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@Tom-Bom-badil
Copy link
Author

Tom-Bom-badil commented Dec 13, 2024

I could not find the public repository providing these custom integration. Could you please point me to it?

Hi Frenck,

see comments to my PR - didn't want to make it available to the public until everything is ready (which includes graphical setup with a logo etc - it's a bit of a chicken and egg situation). However, as you were asking so nicely, I just made it:

https://github.com/Tom-Bom-badil/home-assistant_helios-vallox

Please feel free to comment,
Thanks and cheers, :)

/tom

Edit/ps: Oooops, I commented the PR in detail, but have put the text to the wrong place in the form (into a comment section). So they disappeared in the PR, sorry for that. Corrected.

@Tom-Bom-badil Tom-Bom-badil marked this pull request as ready for review December 13, 2024 18:59
@home-assistant home-assistant bot requested a review from frenck December 13, 2024 18:59
@Tom-Bom-badil Tom-Bom-badil closed this by deleting the head repository Dec 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants