Skip to content

Commit

Permalink
Use single quote in GitHub Action expression
Browse files Browse the repository at this point in the history
  • Loading branch information
@agners
agners committed Aug 14, 2024
1 parent 5ee5b7f commit d9c8501
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion action.yml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ runs:
echo "version=${input}" >> "$GITHUB_OUTPUT"
- shell: bash
if: ${{ inputs.no-pull == "false" }}
if: ${{ inputs.no-pull == 'false' }}
run: |
docker pull ghcr.io/home-assistant/amd64-builder:${{ steps.version.outputs.version }}
cosign verify \
Expand Down

3 comments on commit d9c8501

@invis-z
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add type: boolean for the input then use if: inputs.no-pull? I stole it from https://github.com/smallstep/workflows/blob/0c61a5ee4d6f89b4c6a51bec6cf2ae1e0a34737f/.github/workflows/goCI.yml

@agners
Copy link
Member Author

@agners agners commented on d9c8501 Aug 14, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@invis-z Yeah just noticed, but according to this StackOverflow response the type does not exist.

We'll have to revert to strings I guess 😢

See #218.

@invis-z
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, you are right, just learned that these inputs are not same.

Please sign in to comment.