Use released versions of the builder #214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To build or test the builder, let's use a released version of the builder. This allows to fix the builder in case something got broken with a PR.
When testing, pulling the latest version makes the whole test kinda pointless, as the last version currently published gets tested instead of the just built one. Add a new argument so we can still reuse the same builder action, but skip pulling to reuse the freshly built builder.
|
Once this is merged, we'll see if signing not working was a one-off issue in the Bump sigstore/cosign-installer from 3.5.0 to 3.6.0 (#211) publish action run or if this is reproducible (and most likely caused by #211). If the latter is the case, we'll have to revert #211 and further investigate why the version bump causes issues. |
jbouwh
approved these changes
Aug 12, 2024
frenck
approved these changes
Aug 12, 2024
|
It seems that the new build indeed fixed the problem, the latest image correctly validates again 🤷♂️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To build or test the builder, let's use a released version of the builder. This allows to fix the builder in case something got broken with a PR.
Also make sure that the test build is actually run with the builder just built (instead of pulling the latest version).
This mainly resolves the problem that we have currently a builder on the
:latesttag which appears not properly signed. Unfortunately we can't easily test the signing part currently as signing is only done when publishing. So this might not resolve #212 just yet.