Skip to content

Commit

Permalink
Allow None on Renault binary sensors (#65997)
Browse files Browse the repository at this point in the history
* Enable None on renault binary sensors

* Adjust tests

Co-authored-by: epenet <epenet@users.noreply.github.com>
  • Loading branch information
epenet and epenet authored Feb 7, 2022
1 parent d811393 commit 486c068
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 6 deletions.
7 changes: 3 additions & 4 deletions homeassistant/components/renault/binary_sensor.py
Original file line number Diff line number Diff line change
Expand Up @@ -64,10 +64,9 @@ class RenaultBinarySensor(
@property
def is_on(self) -> bool | None:
"""Return true if the binary sensor is on."""
return (
self._get_data_attr(self.entity_description.on_key)
== self.entity_description.on_value
)
if (data := self._get_data_attr(self.entity_description.on_key)) is None:
return None
return data == self.entity_description.on_value


BINARY_SENSOR_TYPES: tuple[RenaultBinarySensorEntityDescription, ...] = (
Expand Down
4 changes: 2 additions & 2 deletions tests/components/renault/test_binary_sensor.py
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
import pytest

from homeassistant.config_entries import ConfigEntry
from homeassistant.const import STATE_OFF, Platform
from homeassistant.const import STATE_UNKNOWN, Platform
from homeassistant.core import HomeAssistant

from . import (
Expand Down Expand Up @@ -63,7 +63,7 @@ async def test_binary_sensor_empty(

expected_entities = mock_vehicle[Platform.BINARY_SENSOR]
assert len(entity_registry.entities) == len(expected_entities)
check_entities_no_data(hass, entity_registry, expected_entities, STATE_OFF)
check_entities_no_data(hass, entity_registry, expected_entities, STATE_UNKNOWN)


@pytest.mark.usefixtures("fixtures_with_invalid_upstream_exception")
Expand Down

0 comments on commit 486c068

Please sign in to comment.