-
-
Notifications
You must be signed in to change notification settings - Fork 32k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
iRobot Roomba and Braava Integration doesn't work after update to 2024.2.3 #111210
Comments
This is also happening for me PR #110762 was supposed to fix this, but it seems like it didn't |
For me it is failing on the manually configuration. I generate the password using the steps outlined on https://github.com/koalazak/dorita980, but when I submit in HA, it says |
I'm seeing failures after the update to 2024.2.3 too. There are a few tracebacks in the log:
|
Same. Reverted back to 2024.2.2 and Roomba resumed working. So definitely something in this release. |
Hey there @pschmitt, @cyr-ius, @shenxn, @Xitee1, @Orhideous, mind taking a look at this issue as it has been labeled with an integration ( Code owner commandsCode owners of
(message by CodeOwnersMention) roomba documentation |
So this is now fixed, but its not included in the patch release. Since there won't be anymore patch releases this month because the beta starts Wednesday, the easiest is to rollback to 2024.2.2. Or to wait till the first week of march. |
@joostlek Is it possible to manually install the updated/corrected roomba.py? There was a SwitchBot integration that broke like this but you could just download the fixed .py until the official one was released like this here. |
Euh, yes there is, but if i advertise it here, a lot of people will do it and then we get a lot of issues the moment they forget to remove the custom component and forgot they even installed that fix. So yes there is :) If there isn't anything in 2024.2.3 that fixes an issue you have, I'd rather have you rollback to 2024.2.2 instead of trying to patch it. |
Understood. I'll just wait till 2024.3. |
There really ought to be a way to push out a hotfix for something like this which seems to be breaking everyone, instead of asking all users of the integration to just wait ~2 weeks |
I mean this is an issue that only came to light on a production machine, not on our development machines. The users who are affected have both Roomba and mqtt installed. And they should have upgraded to 2024.2.3. Roomba only has 8k active installations which isn't particularly a lot. We have done hotfixes because of integrations before, but that was for ZHA, hue or Shelly, which has waaaay more users. Tldr, the amount of people who are affected isn't enough to issue a hotfix for the whole of core. |
Some of us lost Roomba function in all versions of 2023.02.xx. |
Maybe revert to 2024.2.2 and then run |
I'm hitting this issue as well. Would folks recommend restoring a backup or downgrading via terminal (e.g. running ha core update --version 2024.2.2)? |
Same problem here, after update it broke. "Failed to load" It breaks more often after an update and then I just add the thing again. But this time I add it, klik the submit button. But adding seems to fail beause no entities are bing added and "integration failed to setup". Log says: Logger: homeassistant.config_entries Error setting up entry Roomba for roomba |
I concur with the commits above, 2024.2.3 HA core update broke the Roomba integration. Rolled back to 2024.2.2, Roomba works. |
Same here |
I couldn't add the robot in 2024.2.2 nor in 2024.2.3 I guess I'm stuck till March |
Damn well I justed wasted like an hour of faffing with trying to connect mine.. I should really check git more often 😅 I cannot add a new device. It states there are no devices discovers and then when I manually add the IP address in it just said 'Unkown error' but I could not find the log to know what the error was.. |
well, glad it's not only me 😅 |
manually bumping it to 1.6.13 fixed for me. I guess it was not included in the release. |
Same here, adding robot and controlling it now works |
How are you manually bumping it? Custom deps deployment then putting roombapy==1.6.13 in pypi? |
Wanna know too |
I downgraded via terminal, with that code, and it worked for me. Restoring a backup always loses any energy data for the last day, so I try to avoid it if possible. |
Putting the backup back broke my iBeacons, they are all not detected anymore. And the Skyconnect says all my devices report unknown values. Managed repair the zigbee devices withs sky connect but iBeacon is completely fucked, removing adding nothing works anymore aaagh :(
|
I'm just going to wait a few weeks for the fix, it's just a Roomba 😎. Yes , could roll back again and rebuild, but I'd lose some other changes I made to the FE that I really don't want to edit my .yaml (s) again or hassel with the Lovelace files. It's not that big a deal. The wife won't even notice it's offline as long as everything else works, e.g., motion sensors, lights, weather station, buttons, etc. Appreciate all the work done on HA; thank you. |
tldr as also mentioned in #111030 thread; first add the roomba integration with version 2024.2.3 and then downgrade to 2024.2.2 Just fyi this might be a solution for anyone who wants to get it working again. I didnt know about the update breaking roomba so I first removed the integration. When I tried to add roomba again, it of course still didn't work (hadn't read this thread yet). So I removed the integration again and downgraded to 2024.2.2 with ha core update --version 2024.2.2 (terminal and ssh add-on). When I tried to re-add roomba it gave me another error about not being able to add it. So.... I got it working again by updating to 2024.2.3 again, adding roomba and downgrading to 2024.2.2 again with said command. |
I went through the rigmarole to restore back to a pre-update version, but lost a day’s worth of data and configuration changes I had made since the update. I don’t think most users should have to go through that, and I would concur with those saying a hotfix is warranted. |
Are we sure 1.6.13 is a fix? I added into my Dockefile which just a few things I added on core.
I can see it when I run pip freeze;
but I am still getting errors
and it fails to setup in the UI.. or does HASS in the core image/container not use standard pip locations/something/something. A venv I need to switch to? |
Did you restart HA after updating to 1.6.13? Looks like it's still running
the old version.
…On Sat, Feb 24, 2024, 23:39 Jürgen W ***@***.***> wrote:
Are we sure 1.6.13 is a fix? I added into my Dockefile which just a few
things I added on core.
pip install roombapy==1.6.13
I can see it when I run pip freeze;
roombapy==1.6.13
but I am still getting errors
2024-02-25 16:37:43.422 ERROR (MainThread) [homeassistant.config_entries] Error setting up entry Terrance for roomba
Traceback (most recent call last):
File "/usr/src/homeassistant/homeassistant/config_entries.py", line 444, in async_setup
result = await component.async_setup_entry(hass, self)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/src/homeassistant/homeassistant/components/roomba/__init__.py", line 40, in async_setup_entry
roomba = await hass.async_add_executor_job(
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/local/lib/python3.12/concurrent/futures/thread.py", line 58, in run
result = self.fn(*self.args, **self.kwargs)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/local/lib/python3.12/site-packages/roombapy/roomba_factory.py", line 14, in create_roomba
remote_client = RoombaFactory._create_remote_client(
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/local/lib/python3.12/site-packages/roombapy/roomba_factory.py", line 21, in _create_remote_client
return RoombaRemoteClient(address=address, blid=blid, password=password)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/local/lib/python3.12/site-packages/roombapy/remote_client.py", line 44, in __init__
self.mqtt_client = self._get_mqtt_client()
^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/local/lib/python3.12/site-packages/roombapy/remote_client.py", line 103, in _get_mqtt_client
callback_api_version=mqtt.CallbackAPIVersion.VERSION1,
^^^^^^^^^^^^^^^^^^^^^^^
AttributeError: module 'paho.mqtt.client' has no attribute 'CallbackAPIVersion'
and it fails to setup in the UI
—
Reply to this email directly, view it on GitHub
<#111210 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AMLG6RCCNBTOUEIZKM2SE2TYVLFB5AVCNFSM6AAAAABDW7RRMOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNRSHAZDCNBQHA>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
Yea. I did restart. |
It looks like HA automatically downgrades roomapy to 1.6.12 whenever it starts. Does anyone know if there is a way to bypass that? |
Okay, I was able to make it use 1.6.13 by manually editing homeassistant/components/roomba/manifest.json in my HA installation. |
Yeah, I was suspecting something like this because I found it at v12 again and I am going down another rabbit hole atm. :) |
Yeah, so in the end I had to
to ensure it kept the version at 13, works now. This should work for anyone running core themselves in docker. |
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
Its full shit... |
Not full list broken in the february update:
|
This comment was marked as off-topic.
This comment was marked as off-topic.
I mean, we're all human after all. Mistakes happen and we're doing our best to fix them. I've talked to some other people around the roomba integration and we've learnt our lesson here to not have this caused again. If we'd do a hotfix for every integration that has a regression we'd be at countless releases every month. People are on holiday and most of the people who can create hotfix releases aren't working. I tried to be transparent and temper expectations and all I got was a discussion about people who think they're entitled for a hotfix release because their product is expensive. I am also suffering from this issue myself and I also don't like that this happens. But that's why I try to be transparent so you know what you can expect. Sorry for ruining your weekend and I'm sad to see people from the community rage out because we're doing what we can. We might be trying something, but I can't promise when that lands. |
It's all good... it's just a sub-par vacuum in this case. I appreciate you all for the effort and work put in to make HA great. My Roomba is noisy and annoying anyway so this will be a nice quiet break :) |
I just appreciate the plug-in being updated after what seemed almost a year with no updates... So thank you @joostlek & @Orhideous! |
This is just a vacuum, just wait for the fix, also there are other options you can use in the meantime to use the robot, the official app or even the physical buttons, I do think people are overreacting, there is no guarantee nowhere these integrations will work 100% of the time, accept that and move on 😄 home assistant team, you are doing great and we appreciate your hard work and transparency |
For any critical software in your daily operations, I am surprised you aren’t already holding off until you confirm releases aren’t carrying detrimental bugs. With software that is essential in such a capacity where it can’t be unavailable for a week or two, I’d suggest setting up your own testing environment with another identical home-assistant setup and probably an additional Roomba dedicated to testing; stand up several layers of redundant backups of your docker images, configs, data, volumes/filesysyems, probably across multiple geographic sites for added redundancy in the case you need to fall back onto older versions during disaster recovery. /s @mediacutlet, @HAuser2019 — I don’t mean this in any attacking way or demeaning way. But I want to help illustrate why this isn’t getting fixed at the rate you’re hoping for, and why that expectation might be rooted with some unfair assumptions about the developers giving their time to this project. I hope you’ll roll with me here. All exaggeration of those practices aside (though for real, backup your stuff fully before updating, that’s always good practice), when investing time into Home Assistant and also updating continuously, it’s not too much out of line to say there ought to be a certain amount of risk-acceptance and tinkering-ability if things don’t always work as intended. When relying on software that is 100% free to use in perpetuity, it should go without noting that it’s free usage comes with inherent compromises: you’re not paying anyone to work on or maintain the reliability of that software. That piece of software might not even run in your current setup; your OS and hardware might be fine, but even something so innocent as updating your WiFi password could render part of [any piece of] your setup unusable (looking at you SimpliSafe Camera 😒…) The iRobot app is still very much functional. Our expensive robots are expensive not because the HA community found ways to integrate with them, but because the vendor (iRobot) set the price and we all agreed that it was worth it at the time. I love a good analogy so humor me here (even if for others’ benefit who might not have considered this). You have a walking trail with a little garden alongside it that you like to meander through every day. There is little ground to stand on when volunteers aren’t maintaining that garden in the way you want. It’s communal land, but the state/government doesn’t pay for the gardens to be maintained, it was just a community thing. If the garden is so important to your daily routine, and you’re not able to do the gardening yourself, you’ll need to make a decision:
Having one of the (wonderful) devs who helps maintain this particular code kindly offering up info on a timeline for fixing the problem is more engagement and effective support than what you agreed to when you started using the tool. And that is most often how free things work. Yeah. It’s a bummer that my roomba is temporarily not vacuuming the rug in front of my cats’ litter box every Nth time they poop. But I can still go and use the app that came with the robot (as much as I dislike it nowadays) and I’ll get by. |
The special irony is that I've borked my own Roombas with the code I released and I'm just waiting for a next release. |
Thanks @gkwok1 | Fixed me right up once I figured out, not to copy the whole git folder into HA/config. Update to previous Instructions, unzip the downloaded file, CD into the unzipped roombapy-1.6.13 folder then copy the roombapy folder in to the HA/config: restart. Learned something new today. Thanks all. 👍 |
That was easy... thanks! |
FYI: When I deleted the folder from the HA/config - Roomba stopped working. When I put it back, working again. I'm thinking when the Feb update rolls out, I'll delete the folder in HA then update to 2024.3 and see if it starts working as normal. IMO, probably best to update Roomba via Docker cli commands or just wait for 2024.3 😎 |
Having the roombapy folder in HA/config will override whatever that comes with HA so it will not work if you delete it after getting it working again. Leave the roombapy folder in /config until it's confirm that 1.6.13 is merged into HA's releases. |
My dumb Shark is sitting in the corner after getting an i5, but the shark cleans so much better at half the noise level. About to dump this roomba :) |
Kinda figured that, thanks @gkwok1 |
Dear, HA OS 2024-02-25 23:32:13.145 ERROR (MainThread) [homeassistant.config_entries] Error setting up entry Alfred for roomba |
are you running core yourself? refer to my post you need to change the manifest as well as update the pip version:
IF you do not change the manifest, somewhere along the line HASS reverts.
I would argue it is not just a vacuum, ensuring the place is vacuum'd is heavily tied to the 'WAF' (Wife Acceptance Factor) and if it isn't working I loose my HASS budget, happy wife, happy life and so on. To be fair, I get both sides as I work on both sides but I don't see any harm or problem with putting in a little more effort into the hotfix pipeline so you can push those out at a higher rate and satisfy both worlds and ideally not a discussion for this thread. Thanks again, I got it patched as per my post and I can hear my vacuum's going at full speed and the wife is happy. :P |
Closing this issue as it has been resolved in #111187 and as has been stated, it will be in the next hot fix release. People are talking in this thread like this has been broken for weeks or months and the team is not interested in addressing this, but … it's only been broken since last Thursday. The fix has been merged and it will be in a next hot fix release. It's weekend. Everyone needs to chill out. I also see some people reference WAF. Please note, we don't use that term in in the Home Assistant community. Instead, we use the term Home Approval Factor. I am going to also lock this issue as it seems like some people want to attack the volunteers on this integration personally, and that's not acceptable. Happy Sunday everyone. |
The problem
After Updating via terminal from 2024.2.2 to 2024.2.3 "iRobot Roomba and Braava"-Integration doesn't work any longer.
All devices and entoties are unavailable. Reload integration and restart HA with hardware doesn't help
I'm back to 2024.2.2 an "iRobot Roomba and Braava"-Integration works again.
What version of Home Assistant Core has the issue?
2024.2.3
What was the last working version of Home Assistant Core?
2024.2.2
What type of installation are you running?
Home Assistant Supervised
Integration causing the issue
iRobot Roomba and Braava
Link to integration documentation on our website
No response
Diagnostics information
No response
Example YAML snippet
No response
Anything in the logs that might be useful for us?
No response
Additional information
No response
The text was updated successfully, but these errors were encountered: