Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CalDav: Repeat events do not show in all views #40127

Closed
bverkron opened this issue Sep 16, 2020 · 76 comments · Fixed by #85536
Closed

CalDav: Repeat events do not show in all views #40127

bverkron opened this issue Sep 16, 2020 · 76 comments · Fixed by #85536
Assignees

Comments

@bverkron
Copy link

bverkron commented Sep 16, 2020

The problem

Repeat calendar events do not show beyond the first entry in Monthly and Weekly views. They do, however, render as expected in Daily view. Seems to happen with CalDav but not Google Calendar entries. Might be specific to iCloud calendars, not sure, don't have another CalDav compatible calendar to test with.

Environment

  • Home Assistant Core release with the issue: 0.114.4
  • Last working Home Assistant Core release (if known): Unknown
  • Operating environment (OS/Container/Supervised/Core): Home Assistant OS
  • Integration causing this issue: CalDav
  • Link to integration documentation on our website: https://www.home-assistant.io/integrations/caldav/

Problem-relevant configuration.yaml

calendar:
  - platform: caldav
    username: !secret icloud_username
    password: !secret icloud_app_password
    url: https://caldav.icloud.com
    calendars:
      - Family
      - Errands

Traceback/Error logs

N/A

Additional information

In the monthly and weekly view you can see only a single event (the first one). But moving forward to the 17th (or any day beyond the first one) you can see the repeat events.

monthly

weekly

daily

@probot-home-assistant
Copy link

caldav documentation
caldav source
(message by IssueLinks)

@bverkron bverkron changed the title Calendar: Repeat event do not show in all views Calendar: Repeat events do not show in all views Sep 16, 2020
@alkern
Copy link

alkern commented Sep 18, 2020

Might be specific to iCloud calendars, not sure, don't have another CalDav compatible calendar to test with.

I have the same problem with the Radicale CalDAV server.

In addition to the Calendar view it also happens in the custom calendar card

@bverkron
Copy link
Author

bverkron commented Sep 19, 2020

Issue still present in 0.115.1 in both places (Calendar side panel and Calendar Card).

@jmillnik
Copy link

jmillnik commented Sep 25, 2020

Issue happens to me for Google Calendar events as well. Present in calendar side panel and calendar card.

More specifically, from calendar side panel view, clicking on a date in the calendar loads the day without events showing. Clicking the next (or previous) button and then navigating back to the date does display the event information.

So the events are known but simply don't appear on all views.

@asdrolf
Copy link

asdrolf commented Dec 15, 2020

Have the same issue with Caldav Nextcloud calendar with recurring events.

@elliottjohnson
Copy link

I have the same issue using Baikal Caldav server. Just figured out why Baikal wasn't allowing it to connect sabre-io/dav#1318 and now I'm encountering this issue. I'll look into it some more when I have more time :)

@elliottjohnson
Copy link

elliottjohnson commented Jan 9, 2021

Looking closer at the UI, I don't see that <div class="fc-daygrid-day-events"> is even populated on calendar days on the month view with the event. There is a ::before and an ::after, but no <div class="fc-daygrid-event-harness"> or subsequent divs for the repeated events.

@sandervandegeijn
Copy link

Confirmed for icloud with HA Home Assistant 2021.2.1

A shame, this keeps me from kicking Google out the door.

@docsteel
Copy link

Can confirm for HA 2021 3.3 with DaviCal Server 1.1.9.3

@Chreece
Copy link

Chreece commented Mar 12, 2021

I moved from Google Calendar to Nextcloud and I had the same issue for repeated calendars.
I'm mentioning that because it's been said that Google didn't have this issue

@jmillnik
Copy link

jmillnik commented Mar 12, 2021 via email

@Chreece
Copy link

Chreece commented Mar 12, 2021

Exactly! I have some other problems with CalDav integration, i posted them in another issue #35654 it is open since 10 months!
Let's hope it will be an easy fix and the devs can spend some of their precious time on it...

@jmillnik
Copy link

jmillnik commented Mar 12, 2021 via email

@adrkable
Copy link

I'm seeing the same with Radical CalDAV server.

  • I've tried creating an event than spans across 5 days, HA CalDAV integration only shows an event on the first and last day
  • I also tried just creating a whole day event and repeating that for 5 days - HA CalDAV integration only shows event on first day
  • Also tried creating an event thats 12AM - 11:59PM and repeating that for 5 days - HA CalDAV integration only shows event on first day

@github-actions
Copy link

There hasn't been any activity on this issue recently. Due to the high number of incoming GitHub notifications, we have to clean some of the old issues, as many of them have already been resolved with the latest updates.
Please make sure to update to the latest Home Assistant version and check if that solves the issue. Let us know if that works for you by adding a comment 👍
This issue has now been marked as stale and will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label Jun 23, 2021
@sandervandegeijn
Copy link

Not stale..

@github-actions github-actions bot removed the stale label Jun 23, 2021
@github-actions
Copy link

There hasn't been any activity on this issue recently. Due to the high number of incoming GitHub notifications, we have to clean some of the old issues, as many of them have already been resolved with the latest updates.
Please make sure to update to the latest Home Assistant version and check if that solves the issue. Let us know if that works for you by adding a comment 👍
This issue has now been marked as stale and will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label Sep 21, 2021
@docsteel
Copy link

Issue not solved.

@github-actions github-actions bot removed the stale label Sep 21, 2021
@marksie1988
Copy link

I also see this issue with owncloud and users of my calendar card are reporting the same issue

@ACiDGRiM
Copy link

This is frustrating because I was hoping to rely on this as an alarm in the morning by setting alarms for Weekdays, Saturdays and Sundays. Repeating events are a standard feature of any calendar, not an edge case.

@mathmaniac43
Copy link

This is frustrating because I was hoping to rely on this as an alarm in the morning by setting alarms for Weekdays, Saturdays and Sundays. Repeating events are a standard feature of any calendar, not an edge case.

I have an automation that fires based on a recurring calendar item (via CalDav), and that works every day. Your alarm should work. The only problem is that the monthly and weekly views don't SHOW the repeated calendar entries, even though they do sync into Home Assistant properly.

@ACiDGRiM
Copy link

ACiDGRiM commented Nov 1, 2021

I've recreated the event series several times, the only event that fires is the first in the series, or repeating events that always occur on the same day

I.e. M-f fires on Monday
Saturday repeating fires
Sunday fires

After two weeks of being late to work, thankfully it's remote, I've just relegated to node red repeating inject nodes and have the calendar integration just send me a push notification so I can see if it ever starts working.

@mathmaniac43
Copy link

mathmaniac43 commented Nov 1, 2021 via email

daniele-athome added a commit to daniele-athome/home-assistant that referenced this issue Nov 25, 2022
date_search was deprecated in favour of search which also implements client-side recurring events expansion
@daniele-athome
Copy link
Contributor

I don't think that the timezone object needs to reference a recurrence rule.

I would have the same opinion in principle, but I'm afraid it probably has something to do with the way events are created by the library we use. I'll investigate more on the matter.

@allenporter
Copy link
Contributor

@daniele-athome I tested out your patch and it worked fine with caldav for nextcloud without any special patches, and fixed recurring events. Is there a particular way you have to reproduce the issues you are having?

@ACiDGRiM
Copy link

thanks for the continued word. ive moved more critical alerts to the built in calendar.

however i miss having one place to manage my calendars, it would be nice if this cached events until the next sucessful update since losing internet seemed to drop all calendar events until the next check.

lookingforward to the pr merging

@daniele-athome
Copy link
Contributor

@daniele-athome I tested out your patch and it worked fine with caldav for nextcloud without any special patches, and fixed recurring events. Is there a particular way you have to reproduce the issues you are having?

It might have something to do with the server you're using. According to the original issue Nextcloud is supposed to expand recurring events server-side - so client-side nothing is done. Anyway I used SOGo.

By the way, #84955 was just merged: AFAIU that fixed the problem altogether, so we don't need to patch dateutil. I'll do some more tests because I noticed some strange behaviors so I need to check again.

@allenporter
Copy link
Contributor

I realized it was because the response needed to contain timezone information #81624 (comment)

Anyway, i tested your patch with nextcloud and it definitely works for recurring events. I encourage you to go forward with your bump of the caldav library!

daniele-athome added a commit to daniele-athome/home-assistant that referenced this issue Jan 9, 2023
date_search was deprecated in favour of search which also implements client-side recurring events expansion
daniele-athome added a commit to daniele-athome/home-assistant that referenced this issue Jan 9, 2023
date_search was deprecated in favour of search which also implements client-side recurring events expansion
@daniele-athome
Copy link
Contributor

daniele-athome commented Jan 9, 2023

Everything is ok! The PR is there. I should have done everything correctly.
Thanks everyone for the feedbacks!

EDIT: and tests didn't pass! I'll need to investigate, if anyone has a clue of what is happening though it will definitely speed up the process. Thanks.
EDIT/2: tests are fixed, PR is under review.

daniele-athome added a commit to daniele-athome/home-assistant that referenced this issue Jan 14, 2023
date_search was deprecated in favour of search which also implements client-side recurring events expansion
daniele-athome added a commit to daniele-athome/home-assistant that referenced this issue Jan 14, 2023
date_search was deprecated in favour of search which also implements client-side recurring events expansion
daniele-athome added a commit to daniele-athome/home-assistant that referenced this issue Jan 15, 2023
date_search was deprecated in favour of search which also implements client-side recurring events expansion
daniele-athome added a commit to daniele-athome/home-assistant that referenced this issue Jan 22, 2023
date_search was deprecated in favour of search which also implements client-side recurring events expansion
allenporter pushed a commit that referenced this issue Jan 23, 2023
Upgrade caldav (fix #40127)

date_search was deprecated in favour of search which also implements client-side recurring events expansion
@bkr1969
Copy link

bkr1969 commented Jan 30, 2023

Weird behavior. My Apple calendar recurring event shows up for the first instance, but not further on any given month, yet, if I move to the next month , the last instance of it in the prior month shows up (i.e. the recurring even is on every Tuesday and a new month starts on Wednesday. The "greyed out" last Tuesday of the prior month shows the event, even though non of them show for the current month).

@SlothCroissant
Copy link

Just as an FYI, while at first glance this doesn't appear to be working, I can confirm the entity itself is working as expected:

Home Assistant 2023.1.7
Supervisor 2023.01.1
Operating System 9.5
Frontend 20230110.0 - latest

calendars YAML:

calendar:
  - platform: caldav
    url: https://caldav.icloud.com
    username: **********
    password: **********
    days: 30
    custom_calendars:
      - name: "on_peak"
        calendar: "Time of Use Schedule"
        search: "Peak"

If you see my iCloud calendar, you can see the recurring meeting (I use this to signify when my Electricity is in peak vs off-peak billing):

Screenshot 2023-01-30 at 22 10 59

However, Home Assistant appears to be wonky, only showing the first day in the month (I started this daily repeat on the 2nd):

Screenshot 2023-01-30 at 22 10 21

Yet however again - Home Assistant's calendar.peak entity I have tied to this calendar is working like a charm:

Screenshot 2023-01-30 at 22 08 45

So in summary, check to see if the underlying bits are working - it could be just the calendar UI that is misbehaving.

@tobixen
Copy link

tobixen commented Jan 31, 2023

This is likely to be fixed in the February release, if I'm not mistaken

@daniele-athome
Copy link
Contributor

This is likely to be fixed in the February release, if I'm not mistaken

Yes, it's already in the beta.

@bkr1969
Copy link

bkr1969 commented Feb 2, 2023

Just updated to 2023.2 and it's working perfectly for me.

@tobixen
Copy link

tobixen commented Feb 2, 2023

Please correct me if I'm wrong on this ... but I believe the fix in 2023.2 should work for those calendar servers:

  • radicale
  • google
  • sogo

... but I suspect there may still be problems with recurring events with those calendar servers:

  • xandikos
  • bedework
  • icloud

Those calendar servers are supposed to be fully compliant to recurring events and should work both with 2023.1 and 2023.2:

  • zimbra
  • baikal and nextcloud
  • davical
  • fastmail
  • synology
  • robur

I'm also working on some document with recommendations for calendar servers at https://github.com/tobixen/plann/blob/master/CALENDAR_SERVER_RECOMMENDATIONS.md :-)

@SlothCroissant
Copy link

Confirmed, iCloud is still an issue. I'm running into this now as well, not sure if related, but just FYI

#86938

@dsmanning
Copy link

I've noticed something interesting on iCloud. If I create a repeated event with many events (e.g. every day from February to December) then it will NOT show in Home Assistant. If I reduce the number of repeated events (e.g. stop it on May 31st and start a duplicate repeated event on June 1st) then it WILL show up. Perhaps there is a limit on the number of repeated events?
Hopefully this is useful for a maintainer!

@allenporter
Copy link
Contributor

@dsmanning Hello, if you'd like to report an issue, please file a new issue and fill out the entire info in the bug template. Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.