-
-
Notifications
You must be signed in to change notification settings - Fork 31.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update aioairzone-cloud to v0.3.5 #103315
Conversation
Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com>
Reverts accidental TaskGroup changes. Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com>
Have you tried setting |
No, I haven't tried that. |
Have you tried a semaphore lock in the library to limit the number of requests at the same time instead? |
Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com>
Done in v0.3.5: Thanks for the suggestion @bdraco |
might be a new package publish unrelated
|
published 4 hours ago https://pypi.org/project/jaraco.functools/ |
Yes, dev is failing too... |
Failure in litterrobot isn't related to changes: |
Definitely unrelated. It's likely due to the dst change. |
Thanks @Noltari |
* Update aioairzone-cloud to v0.3.3 Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com> * Update aioairzone-cloud to v0.3.4 Reverts accidental TaskGroup changes. Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com> * Update aioairzone-cloud to v0.3.5 Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com> * Trigger Github CI --------- Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com> Co-authored-by: J. Nick Koston <nick@koston.org>
Proposed change
Update aioairzone-cloud to v0.3.5, which adds a Semaphore that limits the number of API requests performed concurrently.
Update aioairzone-cloud to v0.3.5, which adds support for disabling the use of a shared aiohttp ClientSession.This PR also removes the usage of async_get_clientsession and forces the library to create separate aiohttp client sessions on each request, which fixes the issue for users that have connection hangs when more than 4-5 parallel requests are made to the same host with a shared aiohttp ClientSession.
I know this isn't ideal but it's the only solution I can think of besides limiting the number of concurrent connections to 4.
More context:
Releases:
Git compare: Noltari/aioairzone-cloud@0.3.2...0.3.5
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: