Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add workaround for orjson not handling subclasses of str #105314

Merged
merged 4 commits into from
Dec 8, 2023

Conversation

emontnemery
Copy link
Contributor

Proposed change

Add workaround for orjson not handling subclasses of str

Fixes #105309
Reported on orjson as ijl/orjson#445

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@emontnemery emontnemery added this to the 2023.12.1 milestone Dec 8, 2023
@emontnemery emontnemery requested a review from a team as a code owner December 8, 2023 15:49
@home-assistant home-assistant bot added cla-signed core small-pr PRs with less than 30 lines. labels Dec 8, 2023
@frenck frenck merged commit af715a4 into dev Dec 8, 2023
50 checks passed
@frenck frenck deleted the orjson_derived_class_workaround branch December 8, 2023 17:13
frenck added a commit that referenced this pull request Dec 8, 2023
Co-authored-by: Franck Nijhof <git@frenck.dev>
@frenck frenck mentioned this pull request Dec 8, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Dec 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NodeStrClass fails on from_json call in template engine
3 participants