Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow Alpine 3.18 raspberrypi package updates #105486

Merged
merged 1 commit into from
Dec 11, 2023

Conversation

agners
Copy link
Member

@agners agners commented Dec 11, 2023

Breaking change

Proposed change

Alpine 3.18 renamed the packages raspberrypi and raspberrypi-libs to raspberrypi-userland and raspberrypi-userland-libs respectively. Follow that rename. With this moderniziation raspistill and friends now gets deployed to /usr/bin, which makes any symlinks obsolete.

Note that there is and was never a 64-bit variant of raspistill. So these symlinks were essentially useless all along.

This effectively doesn't change anything for users: Alpine automatically installed the renamed package already and Home Assistant Core picked up the raspistill binary from /usr/bin already.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

Alpine 3.18 renamed the packages raspberrypi and raspberrypi-libs to
raspberrypi-userland and raspberrypi-userland-libs respectively. Follow
that rename. With this moderniziation raspistill and friends now gets
deployed to /usr/bin, which makes any symlinks obsolete.

Note that there is and was never a 64-bit variant of raspistill. So
these symlinks were essentially useless all along.

This effectively doesn't change anything for users: Alpine automatically
installed the renamed package already and Home Assistant Core picked
up the raspistill binary from /usr/bin already.
@agners agners added the docker label Dec 11, 2023
@home-assistant home-assistant bot added cla-signed code-quality small-pr PRs with less than 30 lines. labels Dec 11, 2023
@agners
Copy link
Member Author

agners commented Dec 11, 2023

Note that there is and was never a 64-bit variant of raspistill. So these symlinks were essentially useless all along.

Some background about this can be found here: raspberrypi/userland#688 (comment)

For local camera support, the rpi_camera integration probably should be deprecated and something based on libcamera would make sense.

Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @agners 👍

../Frenck

@agners agners merged commit 44e54e1 into dev Dec 11, 2023
53 checks passed
@agners agners deleted the follow-alpines-raspberrypi-rename branch December 11, 2023 14:58
Bre77 pushed a commit to Bre77/core that referenced this pull request Dec 12, 2023
Alpine 3.18 renamed the packages raspberrypi and raspberrypi-libs to
raspberrypi-userland and raspberrypi-userland-libs respectively. Follow
that rename. With this moderniziation raspistill and friends now gets
deployed to /usr/bin, which makes any symlinks obsolete.

Note that there is and was never a 64-bit variant of raspistill. So
these symlinks were essentially useless all along.

This effectively doesn't change anything for users: Alpine automatically
installed the renamed package already and Home Assistant Core picked
up the raspistill binary from /usr/bin already.
@github-actions github-actions bot locked and limited conversation to collaborators Dec 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants