Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Revert "Add preselect_remember_me to /auth/providers"" #106867

Merged
merged 1 commit into from
Jan 11, 2024

Conversation

edenhaus
Copy link
Contributor

@edenhaus edenhaus commented Jan 2, 2024

Reverts #106472
The reason is that #106462 was merged before the frontend PR was ready and the awaiting-frontend label was overlooked (Soon the Ci will check for it home-assistant/service-hub#236). For that reason the revert #106472 was created and merged. We still want the proposed changes of #106462 and therefore I revert the revert here.

See #106462 for details

@home-assistant
Copy link

home-assistant bot commented Jan 2, 2024

Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration (auth) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of auth can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign auth Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@MartinHjelmare
Copy link
Member

Frontend PR is approved so this is ready to merge.

@edenhaus edenhaus merged commit 1c669c6 into dev Jan 11, 2024
53 checks passed
@edenhaus edenhaus deleted the revert-106472-revert-106462-edenhaus-remeber-me branch January 11, 2024 09:37
@github-actions github-actions bot locked and limited conversation to collaborators Jan 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants