Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add wake up timeout to Teslemetry #109037

Merged
merged 7 commits into from
Feb 22, 2024
Merged

Conversation

Bre77
Copy link
Contributor

@Bre77 Bre77 commented Jan 29, 2024

Proposed change

This PR adds a timeout feature to the wake_up_if_asleep function, with tests. This prevents the function from falling into an infinite loop.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@Bre77 Bre77 closed this Jan 29, 2024
@Bre77 Bre77 reopened this Jan 29, 2024
@gjohansson-ST
Copy link
Member

The main feature of this PR is the timeout and sleeping so it should be renamed. Adding test to add coverage should be it's own PR (if not related to the features you are implementing)

Please undraft once fixed and review can start. Thanks 👍

@gjohansson-ST gjohansson-ST marked this pull request as draft February 5, 2024 18:33
@Bre77 Bre77 changed the title 100% test coverage for Teslemetry Add wake up timeout to Teslemetry Feb 5, 2024
@Bre77 Bre77 marked this pull request as ready for review February 5, 2024 20:07
@Bre77 Bre77 closed this Feb 8, 2024
@Bre77 Bre77 reopened this Feb 8, 2024
@joostlek joostlek added this to the 2024.2.3 milestone Feb 22, 2024
@frenck frenck merged commit 767fcd7 into home-assistant:dev Feb 22, 2024
23 checks passed
@Bre77 Bre77 deleted the teslemetry-wake branch February 22, 2024 10:14
frenck pushed a commit that referenced this pull request Feb 22, 2024
@frenck frenck mentioned this pull request Feb 22, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Feb 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants